From 5baab75fd2ae62b6f6407991922fe234f9e73c88 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Thu, 26 Sep 2024 14:20:16 +0200 Subject: Fix redundant std::optional conversions ...proposed by clang-tidy. Enable bugprone-optional-value-conversion check. --- src/buildtool/system/system_command.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/buildtool/system/system_command.hpp') diff --git a/src/buildtool/system/system_command.hpp b/src/buildtool/system/system_command.hpp index 6f1d80ce..ade2f54b 100644 --- a/src/buildtool/system/system_command.hpp +++ b/src/buildtool/system/system_command.hpp @@ -120,7 +120,7 @@ class SystemCommand { if (auto const err = OpenFile(stderr_file)) { if (auto retval = ForkAndExecute( cmd, envp, cwd, fileno(out.get()), fileno(err.get()))) { - return *retval; + return retval; } } else { -- cgit v1.2.3