From 95f230b3a755f66183ce5c27e929ed6ae3838977 Mon Sep 17 00:00:00 2001
From: Oliver Reiche <oliver.reiche@huawei.com>
Date: Mon, 23 Jun 2025 12:09:21 +0200
Subject: ExecutionApi: Drop DirectorySymlinks from common api

... as it is only needed for local execution, there is no
need to provide it in the common api interface.
---
 src/buildtool/execution_api/common/execution_response.hpp   | 2 --
 src/buildtool/execution_api/local/local_response.hpp        | 2 +-
 src/buildtool/execution_api/remote/bazel/bazel_response.cpp | 9 ---------
 src/buildtool/execution_api/remote/bazel/bazel_response.hpp | 2 --
 4 files changed, 1 insertion(+), 14 deletions(-)

(limited to 'src/buildtool')

diff --git a/src/buildtool/execution_api/common/execution_response.hpp b/src/buildtool/execution_api/common/execution_response.hpp
index 65fd0ba9..552e52a6 100644
--- a/src/buildtool/execution_api/common/execution_response.hpp
+++ b/src/buildtool/execution_api/common/execution_response.hpp
@@ -75,8 +75,6 @@ class IExecutionResponse {
 
     [[nodiscard]] virtual auto Artifacts() noexcept
         -> expected<gsl::not_null<ArtifactInfos const*>, std::string> = 0;
-    [[nodiscard]] virtual auto DirectorySymlinks() noexcept
-        -> expected<gsl::not_null<DirSymlinks const*>, std::string> = 0;
     [[nodiscard]] virtual auto HasUpwardsSymlinks() noexcept
         -> expected<bool, std::string> = 0;
 };
diff --git a/src/buildtool/execution_api/local/local_response.hpp b/src/buildtool/execution_api/local/local_response.hpp
index f5ed3e94..7f50b2fc 100644
--- a/src/buildtool/execution_api/local/local_response.hpp
+++ b/src/buildtool/execution_api/local/local_response.hpp
@@ -112,7 +112,7 @@ class LocalResponse final : public IExecutionResponse {
     }
 
     auto DirectorySymlinks() noexcept
-        -> expected<gsl::not_null<DirSymlinks const*>, std::string> final {
+        -> expected<gsl::not_null<DirSymlinks const*>, std::string> {
         if (auto error_msg = Populate()) {
             return unexpected{*std::move(error_msg)};
         }
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_response.cpp b/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
index e11a3b7f..5d826a1b 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
@@ -88,15 +88,6 @@ auto BazelResponse::Artifacts() noexcept
         &artifacts_);  // explicit type needed for expected
 }
 
-auto BazelResponse::DirectorySymlinks() noexcept
-    -> expected<gsl::not_null<DirSymlinks const*>, std::string> {
-    if (auto error_msg = Populate()) {
-        return unexpected{*std::move(error_msg)};
-    }
-    return gsl::not_null<DirSymlinks const*>(
-        &dir_symlinks_);  // explicit type needed for expected
-}
-
 auto BazelResponse::HasUpwardsSymlinks() noexcept
     -> expected<bool, std::string> {
     if (auto error_msg = Populate()) {
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_response.hpp b/src/buildtool/execution_api/remote/bazel/bazel_response.hpp
index 55f45236..8504ae59 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_response.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_response.hpp
@@ -89,8 +89,6 @@ class BazelResponse final : public IExecutionResponse {
 
     auto Artifacts() noexcept
         -> expected<gsl::not_null<ArtifactInfos const*>, std::string> final;
-    auto DirectorySymlinks() noexcept
-        -> expected<gsl::not_null<DirSymlinks const*>, std::string> final;
     auto HasUpwardsSymlinks() noexcept -> expected<bool, std::string> final;
 
   private:
-- 
cgit v1.2.3