From 0374b80dd407d7b35654a01e3c7526b749d3464e Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 23 Dec 2022 17:18:42 +0100 Subject: Just-MR: Remove wrong pass-by-reference when wrapping loggers Passing the logger by reference would require the caller to be kept alive. Also, being a shared_ptr, the logger can be passed by value at almost no cost. --- src/other_tools/ops_maps/git_update_map.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/other_tools/ops_maps/git_update_map.cpp') diff --git a/src/other_tools/ops_maps/git_update_map.cpp b/src/other_tools/ops_maps/git_update_map.cpp index b1172084..73eccfe0 100644 --- a/src/other_tools/ops_maps/git_update_map.cpp +++ b/src/other_tools/ops_maps/git_update_map.cpp @@ -45,7 +45,7 @@ auto CreateGitUpdateMap(GitCASPtr const& git_cas, std::size_t jobs) } // setup wrapped logger auto wrapped_logger = std::make_shared( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)( fmt::format("While updating commit via tmp repo:\n{}", msg), fatal); -- cgit v1.2.3