From 1394c3d9016373ef727feac9d1aed514e1f89f53 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Wed, 21 Feb 2024 12:08:34 +0100 Subject: just-mr: Correct handling of remotes with respect to compatibility mode In order to set up roots, just-mr is able to interrogate, if given, serve and/or remote-execution endpoints. However, just-mr operates only with Git hashes, i.e., with a native mode CAS. This commit ensures the correct interactions occur between just-mr and the provided endpoints not only in native mode, but also in comaptible mode, where a serve endpoint might be present even if one cannot make use of its associated remote-exection endpoint. The user always gets informed if any incompatibilities are detected. --- src/other_tools/root_maps/root_utils.hpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/other_tools/root_maps/root_utils.hpp') diff --git a/src/other_tools/root_maps/root_utils.hpp b/src/other_tools/root_maps/root_utils.hpp index bf50e04d..d154eb3e 100644 --- a/src/other_tools/root_maps/root_utils.hpp +++ b/src/other_tools/root_maps/root_utils.hpp @@ -37,6 +37,8 @@ /// defined by a given tree by retrieving it from the remote CAS. This method /// ensures the respective tree is in the remote CAS prior to the ServeApi call /// by uploading it to the remote CAS if it is missing. +/// IMPORTANT: No check is performed for the compatibility mode of the protocol +/// used by given remote execution endpoint! /// \param tree_id The Git-tree identifier. /// \param repo_path Local witnessing Git repository for the tree. /// \param remote_api Optional API of the remote-execution endpoint. If nullopt, -- cgit v1.2.3