From 21a0e5ca4c9bb8d8b92822fac7d8dc66b5a4e0e8 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 8 Dec 2023 12:28:10 +0100 Subject: just_serve.proto: Update serve target request The request should only be restricted to the minimal information needed by the remote to answer it. In particular, the execution endpoint address should not be transmitted. --- .../serve_api/serve_service/just_serve.proto | 27 ++++++++++++++++------ 1 file changed, 20 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/buildtool/serve_api/serve_service/just_serve.proto b/src/buildtool/serve_api/serve_service/just_serve.proto index 3472f646..a1803b01 100644 --- a/src/buildtool/serve_api/serve_service/just_serve.proto +++ b/src/buildtool/serve_api/serve_service/just_serve.proto @@ -211,17 +211,30 @@ service SourceTree { } message ServeTargetRequest { - // Digest of the blob containing the target description + // Digest of the blob containing the target description. // - // The client has to guarantee that the blob is present in the remote CAS - // before calling ServeTarget + // The client has to guarantee that the blob has been uploaded to the + // remote CAS. build.bazel.remote.execution.v2.Digest target_cache_key_id = 1; - // Digest of the blob containing the execution backend description + // A single property of the remote execution environment. + message Property { + // Property name + string name = 1; + + // Property value + string value = 2; + } + + // The execution properties. The key-value pairs accumulate, with latest + // value for each key being taken. + repeated Property execution_properties = 2; + + // Digest of the blob containing the endpoint configuration. // - // The client has to guarantee that the blob has been uploaded to the remote - // CAS - build.bazel.remote.execution.v2.Digest execution_backend_description_id = 2; + // The client has to guarantee that the blob has been uploaded to the + // remote CAS. + build.bazel.remote.execution.v2.Digest dispatch_info = 3; } message ServeTargetResponse { -- cgit v1.2.3