From 65b29dfc610d9393337c20e30f5b96e35dffebd0 Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Tue, 4 Apr 2023 12:13:58 +0200 Subject: CAS: demote log messages of to debug As those functions indicate success, it is up to the caller to decide if the error was fatal or not. Reporting an error nevertheless might result in error messages on successful operaitons, which is confusing for the user. --- src/buildtool/execution_api/local/local_api.hpp | 2 +- src/buildtool/storage/local_cas.tpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/buildtool/execution_api/local/local_api.hpp b/src/buildtool/execution_api/local/local_api.hpp index 05fbeeda..7135efa7 100644 --- a/src/buildtool/execution_api/local/local_api.hpp +++ b/src/buildtool/execution_api/local/local_api.hpp @@ -110,7 +110,7 @@ class LocalApi final : public IExecutionApi { storage_->CAS().DumpToStream(info, out, raw_tree); std::fclose(out); if (not success) { - Logger::Log(LogLevel::Error, + Logger::Log(LogLevel::Debug, "dumping {} {} to file descriptor {} failed.", IsTreeObject(info.type) ? "tree" : "blob", info.ToString(), diff --git a/src/buildtool/storage/local_cas.tpp b/src/buildtool/storage/local_cas.tpp index 3664d929..4b91c0e0 100644 --- a/src/buildtool/storage/local_cas.tpp +++ b/src/buildtool/storage/local_cas.tpp @@ -48,7 +48,7 @@ template /*is_hex_id=*/false); } } - Logger::Log(LogLevel::Error, + Logger::Log(LogLevel::Debug, "Tree {} not found in CAS", NativeSupport::Unprefix(digest.hash())); return std::nullopt; -- cgit v1.2.3