From 9a3b4efaef5225ed968fb86a9d7d10ac784ceccf Mon Sep 17 00:00:00 2001
From: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Date: Fri, 5 Jul 2024 13:21:08 +0200
Subject: LocalAction, BazelAction: Extend constness in fields and methods

---
 src/buildtool/execution_api/local/local_action.hpp        | 8 ++++----
 src/buildtool/execution_api/remote/bazel/bazel_action.hpp | 6 +++---
 src/buildtool/execution_api/utils/outputscheck.hpp        | 4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

(limited to 'src')

diff --git a/src/buildtool/execution_api/local/local_action.hpp b/src/buildtool/execution_api/local/local_action.hpp
index 582f9b8e..e62f209f 100644
--- a/src/buildtool/execution_api/local/local_action.hpp
+++ b/src/buildtool/execution_api/local/local_action.hpp
@@ -65,12 +65,12 @@ class LocalAction final : public IExecutionAction {
     Logger logger_{"LocalExecution"};
     StorageConfig const& storage_config_;
     Storage const& storage_;
-    ArtifactDigest root_digest_{};
-    std::vector<std::string> cmdline_{};
+    ArtifactDigest const root_digest_{};
+    std::vector<std::string> const cmdline_{};
     std::vector<std::string> output_files_{};
     std::vector<std::string> output_dirs_{};
-    std::map<std::string, std::string> env_vars_{};
-    std::vector<bazel_re::Platform_Property> properties_;
+    std::map<std::string, std::string> const env_vars_{};
+    std::vector<bazel_re::Platform_Property> const properties_;
     std::chrono::milliseconds timeout_{kDefaultTimeout};
     CacheFlag cache_flag_{CacheFlag::CacheOutput};
 
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
index 8392b1ba..8316cec1 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
@@ -41,13 +41,13 @@ class BazelAction final : public IExecutionAction {
     }
 
   private:
-    std::shared_ptr<BazelNetwork> network_;
+    std::shared_ptr<BazelNetwork> const network_;
     bazel_re::Digest const root_digest_;
     std::vector<std::string> const cmdline_;
     std::vector<std::string> output_files_;
     std::vector<std::string> output_dirs_;
-    std::vector<bazel_re::Command_EnvironmentVariable> env_vars_;
-    std::vector<bazel_re::Platform_Property> properties_;
+    std::vector<bazel_re::Command_EnvironmentVariable> const env_vars_;
+    std::vector<bazel_re::Platform_Property> const properties_;
     CacheFlag cache_flag_{CacheFlag::CacheOutput};
     std::chrono::milliseconds timeout_{kDefaultTimeout};
 
diff --git a/src/buildtool/execution_api/utils/outputscheck.hpp b/src/buildtool/execution_api/utils/outputscheck.hpp
index 13bf5dd2..431a5328 100644
--- a/src/buildtool/execution_api/utils/outputscheck.hpp
+++ b/src/buildtool/execution_api/utils/outputscheck.hpp
@@ -26,8 +26,8 @@
 
 [[nodiscard]] static inline auto ActionResultContainsExpectedOutputs(
     const bazel_re::ActionResult& result,
-    std::vector<std::string> expected_files,
-    std::vector<std::string> expected_dirs) noexcept -> bool {
+    const std::vector<std::string>& expected_files,
+    const std::vector<std::string>& expected_dirs) noexcept -> bool {
     try {
         std::set<std::string> actual_output_files{};
         for (auto const& file : result.output_files()) {
-- 
cgit v1.2.3