From a8516db696890571f454b7a396b71ef567acb17f Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 15 Mar 2024 12:42:42 +0100 Subject: graph_traverser: Remove unnecessary get call ...as it is redundant here and exception prone. --- src/buildtool/graph_traverser/graph_traverser.hpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/buildtool/graph_traverser/graph_traverser.hpp b/src/buildtool/graph_traverser/graph_traverser.hpp index 83876072..c301177a 100644 --- a/src/buildtool/graph_traverser/graph_traverser.hpp +++ b/src/buildtool/graph_traverser/graph_traverser.hpp @@ -139,7 +139,7 @@ class GraphTraverser { if (not artifacts) { return std::nullopt; } - auto const [rel_paths, artifact_nodes, extra_nodes] = *artifacts; + auto [rel_paths, artifact_nodes, extra_nodes] = *artifacts; auto const object_infos = CollectObjectInfos(artifact_nodes); auto extra_infos = CollectObjectInfos(extra_nodes); @@ -168,10 +168,9 @@ class GraphTraverser { artifact_nodes, runfile_descriptions); MaybePrintToStdout(rel_paths, artifact_nodes); - return BuildResult{ - .output_paths = std::move(std::get<0>(*artifacts)), - .extra_infos = std::move(infos), - .failed_artifacts = failed_artifacts}; + return BuildResult{.output_paths = std::move(rel_paths), + .extra_infos = std::move(infos), + .failed_artifacts = failed_artifacts}; } if (clargs_.stage->remember) { -- cgit v1.2.3