From 223f67c2cbf4648c3aaa907ec0edf98e53b574e9 Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 13 Jun 2025 13:14:27 +0200 Subject: Avoid unnecessary work in accessing container entries - in sequence containers, use operator[] instead of .at() when accessing indices guaranteed to be in bound; - in associative containers, prefer .find() and reusing the returned const iterator to using .contains() and .at(); while there, make any so obtained iterators const if they are read-only. --- test/buildtool/build_engine/base_maps/rule_map.test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test/buildtool/build_engine/base_maps/rule_map.test.cpp') diff --git a/test/buildtool/build_engine/base_maps/rule_map.test.cpp b/test/buildtool/build_engine/base_maps/rule_map.test.cpp index f3a64954..2b948a10 100644 --- a/test/buildtool/build_engine/base_maps/rule_map.test.cpp +++ b/test/buildtool/build_engine/base_maps/rule_map.test.cpp @@ -103,9 +103,9 @@ TEST_CASE("Test rule fields", "[rule_map]") { REQUIRE_FALSE((*values[0])->StringFields().empty()); REQUIRE_FALSE((*values[0])->TargetFields().empty()); REQUIRE_FALSE((*values[0])->ConfigFields().empty()); - CHECK((*values[0])->StringFields().at(0) == "foo"); - CHECK((*values[0])->TargetFields().at(0) == "bar"); - CHECK((*values[0])->ConfigFields().at(0) == "baz"); + CHECK((*values[0])->StringFields()[0] == "foo"); + CHECK((*values[0])->TargetFields()[0] == "bar"); + CHECK((*values[0])->ConfigFields()[0] == "baz"); }; SECTION("via file") { -- cgit v1.2.3