From 667017a21482ddbe2bbe4ba056b8c3455e6b3151 Mon Sep 17 00:00:00 2001 From: Alberto Sartori Date: Wed, 30 Mar 2022 12:42:20 +0200 Subject: Eliminate duplicated code in ParseEntityName{FromJson,FromExpression} This patch introduces a templated ParseEntityName which can accept a json or ExpressionPtr. Internally, performs a proper dispatch on these cases - isString - isList - size == 2 - size >= 3 A test is added for checking the proper handling of an empty list --- test/buildtool/build_engine/base_maps/rule_map.test.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'test/buildtool/build_engine/base_maps/rule_map.test.cpp') diff --git a/test/buildtool/build_engine/base_maps/rule_map.test.cpp b/test/buildtool/build_engine/base_maps/rule_map.test.cpp index c0e64675..8667c7a9 100644 --- a/test/buildtool/build_engine/base_maps/rule_map.test.cpp +++ b/test/buildtool/build_engine/base_maps/rule_map.test.cpp @@ -323,6 +323,11 @@ TEST_CASE("Malformed rule description", "[rule_map]") { [](auto /*values*/) { CHECK(false); // should never be called })); + CHECK_FALSE( + ReadUserRule({"", ".", "test_malformed_implicit_entity_name_2"}, + [](auto /*values*/) { + CHECK(false); // should never be called + })); } SECTION("Malformed config_vars") { -- cgit v1.2.3