From 42e82b0f737de367de38567cbe6ee5f158618a2d Mon Sep 17 00:00:00 2001 From: Paul Cristian Sarbu Date: Fri, 9 May 2025 17:20:54 +0200 Subject: GitTree: Ensure all read entries are valid Match behaviour of reading trees, which always checks for invalid entries, also for reading blobs. --- test/buildtool/file_system/git_tree.test.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'test/buildtool/file_system/git_tree.test.cpp') diff --git a/test/buildtool/file_system/git_tree.test.cpp b/test/buildtool/file_system/git_tree.test.cpp index 18309834..1708ccee 100644 --- a/test/buildtool/file_system/git_tree.test.cpp +++ b/test/buildtool/file_system/git_tree.test.cpp @@ -38,7 +38,6 @@ #include "src/buildtool/file_system/object_type.hpp" #include "src/utils/cpp/atomic.hpp" #include "src/utils/cpp/hex_string.hpp" -#include "src/utils/cpp/path.hpp" #include "test/utils/container_matchers.hpp" #include "test/utils/shell_quoting.hpp" @@ -116,8 +115,11 @@ class SymlinksChecker final { std::vector const& ids) const noexcept -> bool { return std::all_of( ids.begin(), ids.end(), [&cas = cas_](ArtifactDigest const& id) { - auto content = cas.ReadObject(id.hash(), /*is_hex_id=*/true); - return content.has_value() and PathIsNonUpwards(*content); + return cas + .ReadObject(id.hash(), + /*is_hex_id=*/true, + /*as_valid_symlink=*/true) + .has_value(); }); }; -- cgit v1.2.3