From c2f7ead468d5e65c57e7ecb49d7fbba4254c46b7 Mon Sep 17 00:00:00 2001
From: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Date: Tue, 2 Jul 2024 16:47:13 +0200
Subject: Replace the Auth and Auth::TLS singletons

Use a builder pattern for creation and validation, in a manner that
allows also other authentication methods to be added in the future
besides the current TLS/SSL.

The main Auth instances are built early and then passed by not_null
const pointers, to avoid passing temporaries, replacing the previous
Auth::TLS instances passed by simple nullable const pointers. Where
needed, these passed Auth instances are also stored, by const ref.

Tests also build Auth instances as needed, either with the default
'no certification' or from the test environment arguments.
---
 .../graph_traverser/graph_traverser_local.test.cpp | 29 +++++++++++++++-------
 1 file changed, 20 insertions(+), 9 deletions(-)

(limited to 'test/buildtool/graph_traverser/graph_traverser_local.test.cpp')

diff --git a/test/buildtool/graph_traverser/graph_traverser_local.test.cpp b/test/buildtool/graph_traverser/graph_traverser_local.test.cpp
index 64d7189b..88990dc8 100644
--- a/test/buildtool/graph_traverser/graph_traverser_local.test.cpp
+++ b/test/buildtool/graph_traverser/graph_traverser_local.test.cpp
@@ -13,59 +13,70 @@
 // limitations under the License.
 
 #include "catch2/catch_test_macros.hpp"
+#include "src/buildtool/auth/authentication.hpp"
 #include "test/buildtool/graph_traverser/graph_traverser.test.hpp"
 #include "test/utils/hermeticity/local.hpp"
+#include "test/utils/remote_execution/test_auth_config.hpp"
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Output created when entry point is local artifact",
                  "[graph_traverser]") {
-    TestCopyLocalFile(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestCopyLocalFile(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Output created and contents are correct",
                  "[graph_traverser]") {
-    TestHelloWorldCopyMessage(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestHelloWorldCopyMessage(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Actions are not re-run",
                  "[graph_traverser]") {
-    TestSequencePrinterBuildLibraryOnly(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestSequencePrinterBuildLibraryOnly(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: KNOWN artifact",
                  "[graph_traverser]") {
-    TestHelloWorldWithKnownSource(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestHelloWorldWithKnownSource(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Blobs uploaded and correctly used",
                  "[graph_traverser]") {
-    TestBlobsUploadedAndUsed(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestBlobsUploadedAndUsed(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Environment variables are set and used",
                  "[graph_traverser]") {
-    TestEnvironmentVariablesSetAndUsed(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestEnvironmentVariablesSetAndUsed(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Trees correctly used",
                  "[graph_traverser]") {
-    TestTreesUsed(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestTreesUsed(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Nested trees correctly used",
                  "[graph_traverser]") {
-    TestNestedTreesUsed(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestNestedTreesUsed(&auth);
 }
 
 TEST_CASE_METHOD(HermeticLocalTestFixture,
                  "Local: Detect flaky actions",
                  "[graph_traverser]") {
-    TestFlakyHelloWorldDetected(/*auth=*/nullptr);
+    Auth auth{}; /*no TLS needed*/
+    TestFlakyHelloWorldDetected(&auth);
 }
-- 
cgit v1.2.3