From 01d9abcfc85d974763c3a7f8fed998342d92a681 Mon Sep 17 00:00:00 2001 From: Oliver Reiche Date: Thu, 27 Jun 2024 17:44:34 +0200 Subject: Use (un)expected for serve API --- .../serve_api/source_tree_client.test.cpp | 25 +++++++++++----------- 1 file changed, 13 insertions(+), 12 deletions(-) (limited to 'test/buildtool/serve_api/source_tree_client.test.cpp') diff --git a/test/buildtool/serve_api/source_tree_client.test.cpp b/test/buildtool/serve_api/source_tree_client.test.cpp index b5650e9f..4d70f2cd 100644 --- a/test/buildtool/serve_api/source_tree_client.test.cpp +++ b/test/buildtool/serve_api/source_tree_client.test.cpp @@ -40,35 +40,36 @@ TEST_CASE("Serve service client: tree-of-commit request", "[serve_api]") { SECTION("Commit in bare checkout") { auto root_id = st_client.ServeCommitTree(kRootCommit, ".", false); - REQUIRE(std::holds_alternative(root_id)); - CHECK(std::get(root_id) == kRootId); + REQUIRE(root_id); + CHECK(*root_id == kRootId); auto baz_id = st_client.ServeCommitTree(kRootCommit, "baz", false); - REQUIRE(std::holds_alternative(baz_id)); - CHECK(std::get(baz_id) == kBazId); + REQUIRE(baz_id); + CHECK(*baz_id == kBazId); } SECTION("Commit in non-bare checkout") { auto root_id = st_client.ServeCommitTree(kRootSymCommit, ".", false); - REQUIRE(std::holds_alternative(root_id)); - CHECK(std::get(root_id) == kRootSymId); + REQUIRE(root_id); + CHECK(*root_id == kRootSymId); auto baz_id = st_client.ServeCommitTree(kRootSymCommit, "baz", false); - REQUIRE(std::holds_alternative(baz_id)); - CHECK(std::get(baz_id) == kBazSymId); + REQUIRE(baz_id); + CHECK(*baz_id == kBazSymId); } SECTION("Subdir not found") { auto root_id = st_client.ServeCommitTree(kRootCommit, "does_not_exist", false); - REQUIRE(std::holds_alternative(root_id)); - CHECK(std::get(root_id)); // fatal failure + REQUIRE_FALSE(root_id); + CHECK(root_id.error() == GitLookupError::Fatal); // fatal failure } SECTION("Commit not known") { auto root_id = st_client.ServeCommitTree( "0123456789abcdef0123456789abcdef01234567", ".", false); - REQUIRE(std::holds_alternative(root_id)); - CHECK_FALSE(std::get(root_id)); // non-fatal failure + REQUIRE_FALSE(root_id); + CHECK_FALSE(root_id.error() == + GitLookupError::Fatal); // non-fatal failure } } -- cgit v1.2.3