From 030af3e7af210617df00bf850476df6b46fb004d Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Mon, 30 Sep 2024 16:16:20 +0200 Subject: Enable readability-* checks. --- test/buildtool/execution_api/common/bytestream_utils.test.cpp | 6 +++--- test/utils/large_objects/large_object_utils.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'test') diff --git a/test/buildtool/execution_api/common/bytestream_utils.test.cpp b/test/buildtool/execution_api/common/bytestream_utils.test.cpp index 1468b156..a2f139e7 100644 --- a/test/buildtool/execution_api/common/bytestream_utils.test.cpp +++ b/test/buildtool/execution_api/common/bytestream_utils.test.cpp @@ -35,7 +35,7 @@ TEST_CASE("ReadRequest", "[common]") { ByteStreamUtils::ReadRequest{kInstanceName, digest}.ToString(); auto const parsed = ByteStreamUtils::ReadRequest::FromString(request); REQUIRE(parsed); - CHECK(parsed->GetInstanceName().compare(kInstanceName) == 0); + CHECK(parsed->GetInstanceName() == kInstanceName); CHECK(std::equal_to{}(parsed->GetDigest(), digest)); } @@ -54,7 +54,7 @@ TEST_CASE("WriteRequest", "[common]") { ByteStreamUtils::WriteRequest{kInstanceName, uuid, digest}.ToString(); auto const parsed = ByteStreamUtils::WriteRequest::FromString(request); REQUIRE(parsed); - CHECK(parsed->GetInstanceName().compare(kInstanceName) == 0); - CHECK(parsed->GetUUID().compare(uuid) == 0); + CHECK(parsed->GetInstanceName() == kInstanceName); + CHECK(parsed->GetUUID() == uuid); CHECK(std::equal_to{}(parsed->GetDigest(), digest)); } diff --git a/test/utils/large_objects/large_object_utils.cpp b/test/utils/large_objects/large_object_utils.cpp index a30a9276..a9342b23 100644 --- a/test/utils/large_objects/large_object_utils.cpp +++ b/test/utils/large_objects/large_object_utils.cpp @@ -30,7 +30,7 @@ class Randomizer final { Randomizer(std::uint64_t min, std::uint64_t max) noexcept : range_(std::random_device{}()), distribution_(min, max) {} - [[nodiscard]] inline auto Get() noexcept -> std::uint64_t { + [[nodiscard]] auto Get() noexcept -> std::uint64_t { return distribution_(range_); } -- cgit v1.2.3