From a0b52e170866b00cd27e243ffd5599be91152395 Mon Sep 17 00:00:00 2001 From: Maksim Denisov Date: Fri, 5 Apr 2024 09:49:02 +0200 Subject: LargeBlobs: Make LocalCAS::BlobPathNoSync public to fix synchronization of executable files during splitting. --- test/buildtool/storage/large_object_cas.test.cpp | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'test') diff --git a/test/buildtool/storage/large_object_cas.test.cpp b/test/buildtool/storage/large_object_cas.test.cpp index 9b0fc90b..7f45c7b8 100644 --- a/test/buildtool/storage/large_object_cas.test.cpp +++ b/test/buildtool/storage/large_object_cas.test.cpp @@ -153,13 +153,6 @@ static void TestLarge() noexcept { CHECK(FileSystemManager::RemoveFile(path)); CHECK_FALSE(FileSystemManager::IsFile(path)); - // For executables the non-executable entry must be also deleted. - if constexpr (kIsExec) { - auto blob_path = cas.BlobPath(digest, /*is_executable=*/false); - REQUIRE(blob_path); - CHECK(FileSystemManager::RemoveFile(*blob_path)); - CHECK_FALSE(FileSystemManager::IsFile(*blob_path)); - } SECTION("Split short-circuting") { // Check the second call loads the entry from the large CAS: @@ -311,14 +304,6 @@ static void TestEmpty() noexcept { CHECK(FileSystemManager::RemoveFile(path)); CHECK_FALSE(FileSystemManager::IsFile(path)); - // For executables the non-executable entry must be also deleted. - if constexpr (kIsExec) { - auto blob_path = cas.BlobPath(digest, /*is_executable=*/false); - REQUIRE(blob_path); - CHECK(FileSystemManager::RemoveFile(*blob_path)); - CHECK_FALSE(FileSystemManager::IsFile(*blob_path)); - } - // Split must not find the large entry: auto pack_2 = kIsTree ? cas.SplitTree(digest) : cas.SplitBlob(digest); auto* error_2 = std::get_if(&pack_2); -- cgit v1.2.3