From dd9fa2841fcb5983b4ea845d5f9dc1b635d8dd18 Mon Sep 17 00:00:00 2001
From: Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com>
Date: Fri, 16 May 2025 17:35:41 +0200
Subject: Executor: Check validity of action outputs in compatible mode

This ensures that any entries that the standard remote execution
protocol accepts but are invalid in justbuild, i.e., upwards
symlinks, are rejected.

For this purpose, do not fail in the action response instances,
just perform the check there, as all required information is
available, and set a flag that the executor can check as needed.
---
 test/buildtool/execution_engine/executor/executor.test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'test')

diff --git a/test/buildtool/execution_engine/executor/executor.test.cpp b/test/buildtool/execution_engine/executor/executor.test.cpp
index 93dd10b6..cba6c977 100644
--- a/test/buildtool/execution_engine/executor/executor.test.cpp
+++ b/test/buildtool/execution_engine/executor/executor.test.cpp
@@ -139,6 +139,10 @@ class TestResponse : public IExecutionResponse {
         static const DirSymlinks kEmptySymlinks{};
         return gsl::not_null<DirSymlinks const*>(&kEmptySymlinks);
     }
+    [[nodiscard]] auto HasUpwardsSymlinks() noexcept
+        -> expected<bool, std::string> final {
+        return false;
+    }
 
   private:
     TestApiConfig config_{};
-- 
cgit v1.2.3