summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaksim Denisov <denisov.maksim@huawei.com>2024-05-24 17:46:49 +0200
committerMaksim Denisov <denisov.maksim@huawei.com>2024-05-28 16:19:19 +0200
commit6184c758d2d7512af94d133f6ecac1abce03490e (patch)
treea6d0f2c915798dee767b43198eed10efe18a3471
parentdc273f4ce89dc6e562c4a99fd394c92f56eeb63f (diff)
downloadjustbuild-6184c758d2d7512af94d133f6ecac1abce03490e.tar.gz
Rename BlobContainer to BazelBlobContainer
-rw-r--r--src/buildtool/execution_api/bazel_msg/TARGETS2
-rw-r--r--src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp (renamed from src/buildtool/execution_api/bazel_msg/bazel_blob.hpp)13
-rw-r--r--src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp2
-rw-r--r--src/buildtool/execution_api/bazel_msg/blob_tree.hpp2
-rw-r--r--src/buildtool/execution_api/common/common_api.cpp6
-rw-r--r--src/buildtool/execution_api/common/execution_api.cpp2
-rw-r--r--src/buildtool/execution_api/common/execution_api.hpp4
-rw-r--r--src/buildtool/execution_api/git/git_api.hpp6
-rw-r--r--src/buildtool/execution_api/local/local_api.hpp6
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_action.cpp6
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_action.hpp2
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_api.cpp6
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_api.hpp2
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp2
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp4
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_network.cpp2
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_network.hpp4
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_network_reader.cpp1
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_response.cpp2
-rw-r--r--src/buildtool/execution_engine/dag/dag.hpp2
-rw-r--r--src/buildtool/execution_engine/executor/executor.hpp12
-rw-r--r--src/buildtool/graph_traverser/graph_traverser.hpp4
-rw-r--r--test/buildtool/execution_api/bazel/bazel_cas_client.test.cpp2
-rw-r--r--test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp4
-rw-r--r--test/buildtool/execution_api/bazel/bazel_network.test.cpp6
-rw-r--r--test/buildtool/execution_api/bazel/bytestream_client.test.cpp2
-rw-r--r--test/buildtool/execution_api/common/api_test.hpp2
-rw-r--r--test/buildtool/execution_api/local/local_execution.test.cpp2
-rw-r--r--test/buildtool/execution_engine/executor/executor.test.cpp2
-rw-r--r--test/buildtool/execution_engine/executor/executor_api.test.hpp6
-rw-r--r--test/buildtool/storage/local_cas.test.cpp2
-rw-r--r--test/utils/blob_creator.hpp2
32 files changed, 63 insertions, 59 deletions
diff --git a/src/buildtool/execution_api/bazel_msg/TARGETS b/src/buildtool/execution_api/bazel_msg/TARGETS
index 6b094ece..2c17b873 100644
--- a/src/buildtool/execution_api/bazel_msg/TARGETS
+++ b/src/buildtool/execution_api/bazel_msg/TARGETS
@@ -1,7 +1,7 @@
{ "bazel_msg":
{ "type": ["@", "rules", "CC", "library"]
, "name": ["bazel_msg"]
- , "hdrs": ["bazel_blob.hpp", "bazel_common.hpp"]
+ , "hdrs": ["bazel_blob_container.hpp", "bazel_common.hpp"]
, "deps":
[ ["src/buildtool/common", "common"]
, ["src/buildtool/file_system", "file_system_manager"]
diff --git a/src/buildtool/execution_api/bazel_msg/bazel_blob.hpp b/src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp
index bac9d273..824c3084 100644
--- a/src/buildtool/execution_api/bazel_msg/bazel_blob.hpp
+++ b/src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp
@@ -12,13 +12,18 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#ifndef INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_HPP
-#define INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_HPP
+#ifndef INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_CONTAINER_HPP
+#define INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_CONTAINER_HPP
+#include <filesystem>
+#include <optional>
+
+#include "src/buildtool/common/artifact_digest.hpp"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/execution_api/common/content_blob_container.hpp"
+#include "src/buildtool/file_system/file_system_manager.hpp"
using BazelBlob = ContentBlob<bazel_re::Digest>;
-using BlobContainer = ContentBlobContainer<bazel_re::Digest>;
+using BazelBlobContainer = ContentBlobContainer<bazel_re::Digest>;
-#endif // INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_HPP
+#endif // INCLUDED_SRC_BUILDTOOL_EXECUTION_API_BAZEL_MSG_BAZEL_BLOB_CONTAINER_HPP
diff --git a/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp b/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp
index e90d862b..5ba658cb 100644
--- a/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp
+++ b/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp
@@ -26,7 +26,7 @@
#include "src/buildtool/common/artifact.hpp"
#include "src/buildtool/common/artifact_digest.hpp"
#include "src/buildtool/common/bazel_types.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_common.hpp"
#include "src/buildtool/execution_api/bazel_msg/directory_tree.hpp"
#include "src/buildtool/execution_engine/dag/dag.hpp"
diff --git a/src/buildtool/execution_api/bazel_msg/blob_tree.hpp b/src/buildtool/execution_api/bazel_msg/blob_tree.hpp
index 781150da..b407e8ee 100644
--- a/src/buildtool/execution_api/bazel_msg/blob_tree.hpp
+++ b/src/buildtool/execution_api/bazel_msg/blob_tree.hpp
@@ -23,7 +23,7 @@
#include "gsl/gsl"
#include "src/buildtool/compatibility/native_support.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/directory_tree.hpp"
class BlobTree;
diff --git a/src/buildtool/execution_api/common/common_api.cpp b/src/buildtool/execution_api/common/common_api.cpp
index d1b3ad03..c3a13fd8 100644
--- a/src/buildtool/execution_api/common/common_api.cpp
+++ b/src/buildtool/execution_api/common/common_api.cpp
@@ -99,7 +99,7 @@ auto CommonUploadBlobTree(BlobTreePtr const& blob_tree,
}
// Process missing blobs.
- BlobContainer container;
+ BazelBlobContainer container;
for (auto const& digest : missing_blobs_info->digests) {
if (auto it = missing_blobs_info->back_map.find(digest);
it != missing_blobs_info->back_map.end()) {
@@ -127,7 +127,7 @@ auto CommonUploadTreeCompatible(
DirectoryTreePtr const& build_root,
BazelMsgFactory::LinkDigestResolveFunc const& resolve_links) noexcept
-> std::optional<ArtifactDigest> {
- BlobContainer blobs{};
+ BazelBlobContainer blobs{};
auto digest = BazelMsgFactory::CreateDirectoryDigestFromTree(
build_root, resolve_links, [&blobs](BazelBlob&& blob) {
blobs.Emplace(std::move(blob));
@@ -167,7 +167,7 @@ auto CommonUploadTreeNative(gsl::not_null<IExecutionApi*> const& api,
"failed to upload blob tree for build root.");
return std::nullopt;
}
- if (not api->Upload(BlobContainer{{tree_blob}},
+ if (not api->Upload(BazelBlobContainer{{tree_blob}},
/*skip_find_missing=*/true)) {
Logger::Log(LogLevel::Debug,
"failed to upload tree blob for build root.");
diff --git a/src/buildtool/execution_api/common/execution_api.cpp b/src/buildtool/execution_api/common/execution_api.cpp
index 49a1414b..b6b16a0f 100644
--- a/src/buildtool/execution_api/common/execution_api.cpp
+++ b/src/buildtool/execution_api/common/execution_api.cpp
@@ -43,7 +43,7 @@
Ensures(false); // unreachable
return false;
}
- BlobContainer container{};
+ BazelBlobContainer container{};
try {
auto exec = IsExecutableObject(type);
container.Emplace(BazelBlob{digest, *data, exec});
diff --git a/src/buildtool/execution_api/common/execution_api.hpp b/src/buildtool/execution_api/common/execution_api.hpp
index 4a40c64e..c4b51780 100644
--- a/src/buildtool/execution_api/common/execution_api.hpp
+++ b/src/buildtool/execution_api/common/execution_api.hpp
@@ -26,7 +26,7 @@
#include "gsl/gsl"
#include "src/buildtool/common/artifact.hpp" // Artifact::ObjectInfo
#include "src/buildtool/common/artifact_digest.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/common/execution_action.hpp"
#include "src/buildtool/execution_engine/dag/dag.hpp"
#include "src/buildtool/file_system/object_type.hpp"
@@ -116,7 +116,7 @@ class IExecutionApi {
/// \param blobs Container of blobs to upload.
/// \param skip_find_missing Skip finding missing blobs, just upload all.
/// NOLINTNEXTLINE(google-default-arguments)
- [[nodiscard]] virtual auto Upload(BlobContainer const& blobs,
+ [[nodiscard]] virtual auto Upload(BazelBlobContainer const& blobs,
bool skip_find_missing = false) noexcept
-> bool = 0;
diff --git a/src/buildtool/execution_api/git/git_api.hpp b/src/buildtool/execution_api/git/git_api.hpp
index 3bbbfd1f..b26654f5 100644
--- a/src/buildtool/execution_api/git/git_api.hpp
+++ b/src/buildtool/execution_api/git/git_api.hpp
@@ -194,7 +194,7 @@ class GitApi final : public IExecutionApi {
// Collect blobs of missing artifacts from local CAS. Trees are
// processed recursively before any blob is uploaded.
- BlobContainer container{};
+ BazelBlobContainer container{};
for (auto const& dgst : missing_artifacts_info->digests) {
auto const& info = missing_artifacts_info->back_map[dgst];
std::optional<std::string> content;
@@ -205,7 +205,7 @@ class GitApi final : public IExecutionApi {
if (not tree) {
return false;
}
- BlobContainer tree_deps_only_blobs{};
+ BazelBlobContainer tree_deps_only_blobs{};
for (auto const& [path, entry] : *tree) {
if (entry->IsTree()) {
if (not RetrieveToCas(
@@ -280,7 +280,7 @@ class GitApi final : public IExecutionApi {
}
/// NOLINTNEXTLINE(google-default-arguments)
- [[nodiscard]] auto Upload(BlobContainer const& /*blobs*/,
+ [[nodiscard]] auto Upload(BazelBlobContainer const& /*blobs*/,
bool /*skip_find_missing*/ = false) noexcept
-> bool override {
// Upload to git cas not supported
diff --git a/src/buildtool/execution_api/local/local_api.hpp b/src/buildtool/execution_api/local/local_api.hpp
index 2f6a1195..91b86de2 100644
--- a/src/buildtool/execution_api/local/local_api.hpp
+++ b/src/buildtool/execution_api/local/local_api.hpp
@@ -33,7 +33,7 @@
#include "src/buildtool/common/repository_config.hpp"
#include "src/buildtool/compatibility/compatibility.hpp"
#include "src/buildtool/compatibility/native_support.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/blob_tree.hpp"
#include "src/buildtool/execution_api/common/common_api.hpp"
#include "src/buildtool/execution_api/common/execution_api.hpp"
@@ -191,7 +191,7 @@ class LocalApi final : public IExecutionApi {
// Collect blobs of missing artifacts from local CAS. Trees are
// processed recursively before any blob is uploaded.
- BlobContainer container{};
+ BazelBlobContainer container{};
for (auto const& dgst : missing_artifacts_info->digests) {
auto const& info = missing_artifacts_info->back_map[dgst];
// Recursively process trees.
@@ -267,7 +267,7 @@ class LocalApi final : public IExecutionApi {
return content;
}
- [[nodiscard]] auto Upload(BlobContainer const& blobs,
+ [[nodiscard]] auto Upload(BazelBlobContainer const& blobs,
bool /*skip_find_missing*/) noexcept
-> bool final {
for (auto const& blob : blobs.Blobs()) {
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_action.cpp b/src/buildtool/execution_api/remote/bazel/bazel_action.cpp
index 7247b2c5..c46de66b 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_action.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_action.cpp
@@ -16,7 +16,7 @@
#include <utility> // std::move
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_response.hpp"
#include "src/buildtool/execution_api/utils/outputscheck.hpp"
@@ -45,7 +45,7 @@ BazelAction::BazelAction(
auto BazelAction::Execute(Logger const* logger) noexcept
-> IExecutionResponse::Ptr {
- BlobContainer blobs{};
+ BazelBlobContainer blobs{};
auto do_cache = CacheEnabled(cache_flag_);
auto action = CreateBundlesForAction(&blobs, root_digest_, not do_cache);
@@ -90,7 +90,7 @@ auto BazelAction::Execute(Logger const* logger) noexcept
return nullptr;
}
-auto BazelAction::CreateBundlesForAction(BlobContainer* blobs,
+auto BazelAction::CreateBundlesForAction(BazelBlobContainer* blobs,
bazel_re::Digest const& exec_dir,
bool do_not_cache) const noexcept
-> bazel_re::Digest {
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
index a01a1695..5abfe57b 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
@@ -58,7 +58,7 @@ class BazelAction final : public IExecutionAction {
std::map<std::string, std::string> const& env_vars,
std::map<std::string, std::string> const& properties) noexcept;
- [[nodiscard]] auto CreateBundlesForAction(BlobContainer* blobs,
+ [[nodiscard]] auto CreateBundlesForAction(BazelBlobContainer* blobs,
bazel_re::Digest const& exec_dir,
bool do_not_cache) const noexcept
-> bazel_re::Digest;
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp
index 042478c4..33561e91 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp
@@ -26,7 +26,7 @@
#include "fmt/core.h"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/compatibility/compatibility.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_common.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp"
#include "src/buildtool/execution_api/common/common_api.hpp"
@@ -60,7 +60,7 @@ namespace {
auto reader = network->ReadBlobs(digests);
auto blobs = reader.Next();
std::size_t count{};
- BlobContainer container{};
+ BazelBlobContainer container{};
while (not blobs.empty()) {
if (count + blobs.size() > size) {
Logger::Log(LogLevel::Warning,
@@ -422,7 +422,7 @@ auto BazelApi::CreateAction(
return std::nullopt;
}
-[[nodiscard]] auto BazelApi::Upload(BlobContainer const& blobs,
+[[nodiscard]] auto BazelApi::Upload(BazelBlobContainer const& blobs,
bool skip_find_missing) noexcept -> bool {
return network_->UploadBlobs(blobs, skip_find_missing);
}
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.hpp b/src/buildtool/execution_api/remote/bazel/bazel_api.hpp
index 3411b6b7..49827922 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_api.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_api.hpp
@@ -80,7 +80,7 @@ class BazelApi final : public IExecutionApi {
std::vector<Artifact::ObjectInfo> const& artifacts_info,
gsl::not_null<IExecutionApi*> const& api) noexcept -> bool final;
- [[nodiscard]] auto Upload(BlobContainer const& blobs,
+ [[nodiscard]] auto Upload(BazelBlobContainer const& blobs,
bool skip_find_missing) noexcept -> bool final;
[[nodiscard]] auto UploadTree(
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
index 3b85198e..5feabb57 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp
@@ -188,7 +188,7 @@ auto BazelCasClient::FindMissingBlobs(
auto BazelCasClient::FindMissingBlobs(
std::string const& instance_name,
- BlobContainer const& blob_container) noexcept
+ BazelBlobContainer const& blob_container) noexcept
-> std::vector<bazel_re::Digest> {
auto digests_range = blob_container.Digests();
return FindMissingBlobs(
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp
index 8239107b..92c4a019 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp
@@ -27,7 +27,7 @@
#include "gsl/gsl"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/common/remote/port.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_common.hpp"
#include "src/buildtool/execution_api/remote/bazel/bytestream_client.hpp"
#include "src/buildtool/execution_api/remote/config.hpp"
@@ -54,7 +54,7 @@ class BazelCasClient {
/// \returns The digests of blobs not found in CAS
[[nodiscard]] auto FindMissingBlobs(
std::string const& instance_name,
- BlobContainer const& blob_container) noexcept
+ BazelBlobContainer const& blob_container) noexcept
-> std::vector<bazel_re::Digest>;
/// \brief Upload multiple blobs in batch transfer
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_network.cpp b/src/buildtool/execution_api/remote/bazel/bazel_network.cpp
index 34fe49c7..a537dcdc 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_network.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_network.cpp
@@ -99,7 +99,7 @@ auto BazelNetwork::DoUploadBlobs(T_Iter const& first,
}
}
-auto BazelNetwork::UploadBlobs(BlobContainer const& blobs,
+auto BazelNetwork::UploadBlobs(BazelBlobContainer const& blobs,
bool skip_find_missing) noexcept -> bool {
if (skip_find_missing) {
auto blob_range = blobs.Blobs();
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_network.hpp b/src/buildtool/execution_api/remote/bazel/bazel_network.hpp
index 2eb7a243..3e2c03fe 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_network.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_network.hpp
@@ -25,7 +25,7 @@
#include "gsl/gsl"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/common/remote/port.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp"
#include "src/buildtool/execution_api/common/execution_api.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_ac_client.hpp"
@@ -90,7 +90,7 @@ class BazelNetwork {
/// \param blobs The blobs to upload
/// \param skip_find_missing Skip finding missing blobs, just upload all
/// \returns True if upload was successful, false otherwise
- [[nodiscard]] auto UploadBlobs(BlobContainer const& blobs,
+ [[nodiscard]] auto UploadBlobs(BazelBlobContainer const& blobs,
bool skip_find_missing = false) noexcept
-> bool;
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_network_reader.cpp b/src/buildtool/execution_api/remote/bazel/bazel_network_reader.cpp
index a0e96237..90790ef4 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_network_reader.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_network_reader.cpp
@@ -17,7 +17,6 @@
#include <algorithm>
#include "src/buildtool/crypto/hash_function.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp"
#include "src/buildtool/file_system/file_system_manager.hpp"
#include "src/buildtool/logging/log_level.hpp"
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_response.cpp b/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
index 3ea82219..9db3bb94 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_response.cpp
@@ -212,7 +212,7 @@ auto BazelResponse::Populate() noexcept -> bool {
auto BazelResponse::UploadTreeMessageDirectories(
bazel_re::Tree const& tree) const -> std::optional<ArtifactDigest> {
- BlobContainer dir_blobs{};
+ BazelBlobContainer dir_blobs{};
auto rootdir_blob = ProcessDirectoryMessage(tree.root());
if (not rootdir_blob) {
diff --git a/src/buildtool/execution_engine/dag/dag.hpp b/src/buildtool/execution_engine/dag/dag.hpp
index b371896b..b52e5beb 100644
--- a/src/buildtool/execution_engine/dag/dag.hpp
+++ b/src/buildtool/execution_engine/dag/dag.hpp
@@ -450,7 +450,7 @@ class DependencyGraph : DirectedAcyclicGraph {
// Collect paths from named nodes.
// TODO(oreiche): This could be potentially speed up by using a wrapper
- // iterator to provide a read-only view (similar to BlobContainer)
+ // iterator to provide a read-only view (similar to BazelBlobContainer)
[[nodiscard]] static auto NodePaths(
std::vector<NamedOtherNodePtr> const& nodes)
-> std::vector<Action::LocalPath> {
diff --git a/src/buildtool/execution_engine/executor/executor.hpp b/src/buildtool/execution_engine/executor/executor.hpp
index b7eb98cf..7f931cbd 100644
--- a/src/buildtool/execution_engine/executor/executor.hpp
+++ b/src/buildtool/execution_engine/executor/executor.hpp
@@ -295,7 +295,7 @@ class ExecutorImpl {
}
// upload missing entries (blobs or trees)
- BlobContainer container;
+ BazelBlobContainer container;
for (auto const& digest : missing_digests) {
if (auto it = entry_map.find(digest); it != entry_map.end()) {
auto const& entry = it->second;
@@ -361,7 +361,7 @@ class ExecutorImpl {
}
// upload artifact content
- auto container = BlobContainer{{BazelBlob{
+ auto container = BazelBlobContainer{{BazelBlob{
info.digest, std::move(*content), IsExecutableObject(info.type)}}};
return api->Upload(container, /*skip_find_missing=*/true);
}
@@ -447,10 +447,10 @@ class ExecutorImpl {
return std::nullopt;
}
auto digest = ArtifactDigest::Create<ObjectType::File>(*content);
- if (not api->Upload(
- BlobContainer{{BazelBlob{digest,
- std::move(*content),
- IsExecutableObject(*object_type)}}})) {
+ if (not api->Upload(BazelBlobContainer{
+ {BazelBlob{digest,
+ std::move(*content),
+ IsExecutableObject(*object_type)}}})) {
return std::nullopt;
}
return Artifact::ObjectInfo{.digest = std::move(digest),
diff --git a/src/buildtool/graph_traverser/graph_traverser.hpp b/src/buildtool/graph_traverser/graph_traverser.hpp
index 4b4a6ff5..3f86568f 100644
--- a/src/buildtool/graph_traverser/graph_traverser.hpp
+++ b/src/buildtool/graph_traverser/graph_traverser.hpp
@@ -36,7 +36,7 @@
#include "src/buildtool/common/repository_config.hpp"
#include "src/buildtool/common/statistics.hpp"
#include "src/buildtool/common/tree.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/common/create_execution_api.hpp"
#include "src/buildtool/execution_api/local/local_api.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_api.hpp"
@@ -322,7 +322,7 @@ class GraphTraverser {
/// \param[in] blobs blobs to be uploaded
[[nodiscard]] auto UploadBlobs(
std::vector<std::string> const& blobs) const noexcept -> bool {
- BlobContainer container;
+ BazelBlobContainer container;
for (auto const& blob : blobs) {
auto digest = ArtifactDigest::Create<ObjectType::File>(blob);
Logger::Log(logger_, LogLevel::Trace, [&]() {
diff --git a/test/buildtool/execution_api/bazel/bazel_cas_client.test.cpp b/test/buildtool/execution_api/bazel/bazel_cas_client.test.cpp
index 26e741fb..d9fec4dc 100644
--- a/test/buildtool/execution_api/bazel/bazel_cas_client.test.cpp
+++ b/test/buildtool/execution_api/bazel/bazel_cas_client.test.cpp
@@ -19,7 +19,7 @@
#include "catch2/catch_test_macros.hpp"
#include "gsl/gsl"
#include "src/buildtool/common/artifact_digest.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_cas_client.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_execution_client.hpp"
#include "src/buildtool/execution_api/remote/config.hpp"
diff --git a/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp b/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
index 6715a565..730420e9 100644
--- a/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
+++ b/test/buildtool/execution_api/bazel/bazel_msg_factory.test.cpp
@@ -17,7 +17,7 @@
#include "catch2/catch_test_macros.hpp"
#include "src/buildtool/common/artifact_factory.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/bazel_msg/bazel_msg_factory.hpp"
#include "src/buildtool/file_system/file_system_manager.hpp"
#include "src/buildtool/file_system/object_type.hpp"
@@ -89,7 +89,7 @@ TEST_CASE("Bazel internals: MessageFactory", "[execution_api]") {
{link_blob->digest, link}};
// create blobs via tree
- BlobContainer blobs{};
+ BazelBlobContainer blobs{};
REQUIRE(BazelMsgFactory::CreateDirectoryDigestFromTree(
*tree,
[&fake_cas](std::vector<bazel_re::Digest> const& digests,
diff --git a/test/buildtool/execution_api/bazel/bazel_network.test.cpp b/test/buildtool/execution_api/bazel/bazel_network.test.cpp
index 240e3a16..9125fbc4 100644
--- a/test/buildtool/execution_api/bazel/bazel_network.test.cpp
+++ b/test/buildtool/execution_api/bazel/bazel_network.test.cpp
@@ -19,7 +19,7 @@
#include "catch2/catch_test_macros.hpp"
#include "src/buildtool/common/artifact_digest.hpp"
#include "src/buildtool/compatibility/compatibility.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_execution_client.hpp"
#include "src/buildtool/execution_api/remote/bazel/bazel_network.hpp"
#include "src/buildtool/execution_api/remote/config.hpp"
@@ -47,7 +47,7 @@ TEST_CASE("Bazel network: write/read blobs", "[execution_api]") {
/*is_exec=*/false};
// Search blobs via digest
- REQUIRE(network.UploadBlobs(BlobContainer{{foo, bar, baz}}));
+ REQUIRE(network.UploadBlobs(BazelBlobContainer{{foo, bar, baz}}));
// Read blobs in order
auto reader = network.ReadBlobs(
@@ -91,7 +91,7 @@ TEST_CASE("Bazel network: read blobs with unknown size", "[execution_api]") {
/*is_exec=*/false};
// Upload blobs
- REQUIRE(network.UploadBlobs(BlobContainer{{foo, bar}}));
+ REQUIRE(network.UploadBlobs(BazelBlobContainer{{foo, bar}}));
// Set size to unknown
foo.digest.set_size_bytes(0);
diff --git a/test/buildtool/execution_api/bazel/bytestream_client.test.cpp b/test/buildtool/execution_api/bazel/bytestream_client.test.cpp
index bf6db6db..285ec7d7 100644
--- a/test/buildtool/execution_api/bazel/bytestream_client.test.cpp
+++ b/test/buildtool/execution_api/bazel/bytestream_client.test.cpp
@@ -17,7 +17,7 @@
#include "catch2/catch_test_macros.hpp"
#include "src/buildtool/common/artifact_digest.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/execution_api/common/execution_common.hpp"
#include "src/buildtool/execution_api/remote/bazel/bytestream_client.hpp"
#include "src/buildtool/execution_api/remote/config.hpp"
diff --git a/test/buildtool/execution_api/common/api_test.hpp b/test/buildtool/execution_api/common/api_test.hpp
index ac8925f0..8d869116 100644
--- a/test/buildtool/execution_api/common/api_test.hpp
+++ b/test/buildtool/execution_api/common/api_test.hpp
@@ -217,7 +217,7 @@ inline void SetLauncher() {
std::string output_path{"output_file"};
auto api = api_factory();
- CHECK(api->Upload(BlobContainer{{BazelBlob{
+ CHECK(api->Upload(BazelBlobContainer{{BazelBlob{
test_digest, test_content, /*is_exec=*/false}}},
false));
diff --git a/test/buildtool/execution_api/local/local_execution.test.cpp b/test/buildtool/execution_api/local/local_execution.test.cpp
index c55449e0..860f4c3e 100644
--- a/test/buildtool/execution_api/local/local_execution.test.cpp
+++ b/test/buildtool/execution_api/local/local_execution.test.cpp
@@ -216,7 +216,7 @@ TEST_CASE_METHOD(HermeticLocalTestFixture,
std::string test_content("test");
auto test_digest = ArtifactDigest::Create<ObjectType::File>(test_content);
- REQUIRE(api.Upload(BlobContainer{{BazelBlob{
+ REQUIRE(api.Upload(BazelBlobContainer{{BazelBlob{
test_digest, test_content, /*is_exec=*/false}}},
false));
diff --git a/test/buildtool/execution_engine/executor/executor.test.cpp b/test/buildtool/execution_engine/executor/executor.test.cpp
index 02836d07..7a09dc84 100644
--- a/test/buildtool/execution_engine/executor/executor.test.cpp
+++ b/test/buildtool/execution_engine/executor/executor.test.cpp
@@ -174,7 +174,7 @@ class TestApi : public IExecutionApi {
-> std::optional<std::string> override {
return std::nullopt; // not needed by Executor
}
- auto Upload(BlobContainer const& blobs, bool /*unused*/) noexcept
+ auto Upload(BazelBlobContainer const& blobs, bool /*unused*/) noexcept
-> bool final {
auto blob_range = blobs.Blobs();
return std::all_of(
diff --git a/test/buildtool/execution_engine/executor/executor_api.test.hpp b/test/buildtool/execution_engine/executor/executor_api.test.hpp
index 1ff50831..c8ec19d7 100644
--- a/test/buildtool/execution_engine/executor/executor_api.test.hpp
+++ b/test/buildtool/execution_engine/executor/executor_api.test.hpp
@@ -51,7 +51,7 @@ static inline void RunBlobUpload(RepositoryConfig* repo_config,
SetupConfig(repo_config);
auto api = factory();
std::string const blob = "test";
- CHECK(api->Upload(BlobContainer{{BazelBlob{
+ CHECK(api->Upload(BazelBlobContainer{{BazelBlob{
ArtifactDigest{HashFunction::ComputeBlobHash(blob).HexString(),
blob.size(),
/*is_tree=*/false},
@@ -383,8 +383,8 @@ static inline void TestUploadAndDownloadTrees(
// upload blobs
auto api = factory();
REQUIRE(api->Upload(
- BlobContainer{{BazelBlob{foo_digest, foo, /*is_exec=*/false},
- BazelBlob{bar_digest, bar, /*is_exec=*/false}}}));
+ BazelBlobContainer{{BazelBlob{foo_digest, foo, /*is_exec=*/false},
+ BazelBlob{bar_digest, bar, /*is_exec=*/false}}}));
// define known artifacts
auto foo_desc = ArtifactDescription{foo_digest, ObjectType::File};
diff --git a/test/buildtool/storage/local_cas.test.cpp b/test/buildtool/storage/local_cas.test.cpp
index 512e9a1b..55a8d946 100644
--- a/test/buildtool/storage/local_cas.test.cpp
+++ b/test/buildtool/storage/local_cas.test.cpp
@@ -17,7 +17,7 @@
#include "catch2/catch_test_macros.hpp"
#include "src/buildtool/common/artifact_digest.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/file_system/file_system_manager.hpp"
#include "src/buildtool/file_system/object_type.hpp"
#include "test/utils/blob_creator.hpp"
diff --git a/test/utils/blob_creator.hpp b/test/utils/blob_creator.hpp
index 3bc7d54c..baa7cc86 100644
--- a/test/utils/blob_creator.hpp
+++ b/test/utils/blob_creator.hpp
@@ -20,7 +20,7 @@
#include <string>
#include "src/buildtool/common/artifact_digest.hpp"
-#include "src/buildtool/execution_api/bazel_msg/bazel_blob.hpp"
+#include "src/buildtool/execution_api/bazel_msg/bazel_blob_container.hpp"
#include "src/buildtool/file_system/file_system_manager.hpp"
#include "src/buildtool/file_system/object_type.hpp"