diff options
| author | Maksim Denisov <denisov.maksim@huawei.com> | 2025-02-25 13:46:17 +0100 |
|---|---|---|
| committer | Maksim Denisov <denisov.maksim@huawei.com> | 2025-02-27 09:03:30 +0100 |
| commit | a9f1d97f3b288df2b490665ae88b62407ef97ca7 (patch) | |
| tree | 5aabdb7a70c598ee98d148a8d2c5f1ed52c06c49 | |
| parent | 461312b57d3b49f92861d2c6c5e8a6b13ffa839b (diff) | |
| download | justbuild-a9f1d97f3b288df2b490665ae88b62407ef97ca7.tar.gz | |
Remove BytestreamClient test.
ArtifactBlob rehashes content, there's no way to construct it with a wrong digest.
| -rw-r--r-- | test/buildtool/execution_api/bazel/TARGETS | 2 | ||||
| -rw-r--r-- | test/buildtool/execution_api/bazel/bytestream_client.test.cpp | 15 |
2 files changed, 0 insertions, 17 deletions
diff --git a/test/buildtool/execution_api/bazel/TARGETS b/test/buildtool/execution_api/bazel/TARGETS index 25fbda81..230c6f48 100644 --- a/test/buildtool/execution_api/bazel/TARGETS +++ b/test/buildtool/execution_api/bazel/TARGETS @@ -54,8 +54,6 @@ , ["@", "grpc", "", "grpc"] , ["@", "gsl", "", "gsl"] , ["@", "src", "src/buildtool/common", "artifact_blob"] - , ["@", "src", "src/buildtool/common", "artifact_digest_factory"] - , ["@", "src", "src/buildtool/common", "common"] , ["@", "src", "src/buildtool/common/remote", "remote_common"] , ["@", "src", "src/buildtool/crypto", "hash_function"] , ["@", "src", "src/buildtool/execution_api/common", "common"] diff --git a/test/buildtool/execution_api/bazel/bytestream_client.test.cpp b/test/buildtool/execution_api/bazel/bytestream_client.test.cpp index 823c317c..49a88109 100644 --- a/test/buildtool/execution_api/bazel/bytestream_client.test.cpp +++ b/test/buildtool/execution_api/bazel/bytestream_client.test.cpp @@ -24,8 +24,6 @@ #include "catch2/catch_test_macros.hpp" #include "gsl/gsl" #include "src/buildtool/common/artifact_blob.hpp" -#include "src/buildtool/common/artifact_digest.hpp" -#include "src/buildtool/common/artifact_digest_factory.hpp" #include "src/buildtool/common/remote/remote_common.hpp" #include "src/buildtool/crypto/hash_function.hpp" #include "src/buildtool/execution_api/remote/config.hpp" @@ -69,19 +67,6 @@ TEST_CASE("ByteStream Client: Transfer single blob", "[execution_api]") { CHECK(*downloaded_content == content); } - SECTION("Small blob with wrong digest") { - std::string instance_name{"remote-execution"}; - std::string content("foobar"); - std::string other_content("This is a differnt string"); - - // Valid digest, but for a different string - auto digest = ArtifactDigestFactory::HashDataAs<ObjectType::File>( - hash_function, other_content); - ArtifactBlob const blob{digest, content, /*is_exec=*/false}; - - CHECK(not stream.Write(instance_name, blob)); - } - SECTION("Upload large blob") { static constexpr std::size_t kLargeSize = GRPC_DEFAULT_MAX_RECV_MESSAGE_LENGTH + 1; |