diff options
author | Oliver Reiche <oliver.reiche@huawei.com> | 2023-02-24 15:49:14 +0100 |
---|---|---|
committer | Oliver Reiche <oliver.reiche@huawei.com> | 2023-03-13 17:28:59 +0100 |
commit | 42b452e72f536b63bac080880b8daa481099793c (patch) | |
tree | 0af1a60e5e0fefb5572df38e092def3d8ac74c05 /src/buildtool/build_engine/target_map/target_cache.cpp | |
parent | 546bf5beebf2eb75e7b325f8f18969b4dd34a169 (diff) | |
download | justbuild-42b452e72f536b63bac080880b8daa481099793c.tar.gz |
Storage: Reworked storage and garbage collection
The improved GC implementation uses refactored storage
classes instead of directly accessing "unknown" file paths.
The required storage class refactoring is quite substantial
and outlined in the following paragraphs.
The module `buildtool/file_system` was extended by:
- `ObjectCAS`: a plain CAS implementation for
reading/writing blobs and computing digests for a given
`ObjectType`. Depending on that type, files written to the
file system may have different properties (e.g., the x-bit
set) or the digest may be computed differently (e.g., tree
digests in non-compatible mode).
A new module `buildtool/storage` was introduced containing:
- `LocalCAS`: provides a common interface for the "logical
CAS", which internally combines three `ObjectCAS`s, one
for each `ObjectType` (file, executable, tree).
- `LocalAC`: implements the action cache, which needs the
`LocalCAS` for storing cache values.
- `TargetCache`: implements the high-level target cache,
which also needs the `LocalCAS` for storing cache values.
- `LocalStorage`: combines the storage classes `LocalCAS`,
`LocalAC`, and `TargetCache`. Those are initialized with
settings from `StorageConfig`, such as the build root base
path or number of generations for the garbage collector.
`LocalStorage` is templated with a Boolean parameter
`kDoGlobalUplink`, which indicates that, on every
read/write access, the garbage collector should be used
for uplinking across all generations (global).
- `GarbageCollector`: responsible for garbage collection and
the global uplinking across all generations. To do so, it
employs instances of `LocalStorage` with `kDoGlobalUplink`
set to false, in order to avoid endless recursion. The
actual (local) uplinking within two single generations is
performed by the corresponding storage class (e.g.,
`TargetCache` implements uplinking of target cache entries
between two target cache generations etc.). Thereby, the
actual knowledge how data should be uplinked is
implemented by the instance that is responsible for
creating the data in the first place.
Diffstat (limited to 'src/buildtool/build_engine/target_map/target_cache.cpp')
-rw-r--r-- | src/buildtool/build_engine/target_map/target_cache.cpp | 105 |
1 files changed, 0 insertions, 105 deletions
diff --git a/src/buildtool/build_engine/target_map/target_cache.cpp b/src/buildtool/build_engine/target_map/target_cache.cpp deleted file mode 100644 index 3e149ddd..00000000 --- a/src/buildtool/build_engine/target_map/target_cache.cpp +++ /dev/null @@ -1,105 +0,0 @@ -// Copyright 2022 Huawei Cloud Computing Technology Co., Ltd. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -#include "src/buildtool/build_engine/target_map/target_cache.hpp" - -#include <exception> -#include <vector> - -#include <fmt/core.h> - -#include "src/buildtool/common/artifact_digest.hpp" -#include "src/buildtool/execution_api/local/config.hpp" -#include "src/buildtool/file_system/file_system_manager.hpp" -#include "src/buildtool/logging/log_level.hpp" -#ifndef BOOTSTRAP_BUILD_TOOL -#include "src/buildtool/execution_api/local/garbage_collector.hpp" -#endif - -auto TargetCache::Store(TargetCacheKey const& key, - TargetCacheEntry const& value, - ArtifactDownloader const& downloader) const noexcept - -> bool { - // Before a target-cache entry is stored in local CAS, make sure any created - // artifact for this target is downloaded from the remote CAS to the local - // CAS. - if (not DownloadKnownArtifacts(value, downloader)) { - return false; - } - if (auto digest = CAS().StoreBlobFromBytes(value.ToJson().dump(2))) { - auto data = - Artifact::ObjectInfo{ArtifactDigest{*digest}, ObjectType::File} - .ToString(); - logger_.Emit(LogLevel::Debug, - "Adding entry for key {} as {}", - key.Id().ToString(), - data); - return file_store_.AddFromBytes(key.Id().digest.hash(), data); - } - return false; -} - -auto TargetCache::Read(TargetCacheKey const& key) const noexcept - -> std::optional<std::pair<TargetCacheEntry, Artifact::ObjectInfo> > { - auto id = key.Id().digest.hash(); - auto entry_path = file_store_.GetPath(id); -#ifndef BOOTSTRAP_BUILD_TOOL - // Try to find target-cache entry in CAS generations and uplink if required. - auto found = GarbageCollector::FindAndUplinkTargetCacheEntry(id); -#else - auto found = FileSystemManager::IsFile(entry_path); -#endif - if (not found) { - logger_.Emit(LogLevel::Debug, - "Cache miss, entry not found {}", - entry_path.string()); - return std::nullopt; - } - auto const entry = - FileSystemManager::ReadFile(entry_path, ObjectType::File); - if (auto info = Artifact::ObjectInfo::FromString(*entry)) { - if (auto path = CAS().BlobPath(info->digest)) { - if (auto value = FileSystemManager::ReadFile(*path)) { - try { - return std::make_pair( - TargetCacheEntry{nlohmann::json::parse(*value)}, - std::move(*info)); - } catch (std::exception const& ex) { - logger_.Emit(LogLevel::Warning, - "Parsing entry for key {} failed with:\n{}", - key.Id().ToString(), - ex.what()); - } - } - } - } - logger_.Emit(LogLevel::Warning, - "Reading entry for key {} failed", - key.Id().ToString()); - return std::nullopt; -} - -auto TargetCache::DownloadKnownArtifacts( - TargetCacheEntry const& value, - ArtifactDownloader const& downloader) const noexcept -> bool { - std::vector<Artifact::ObjectInfo> artifacts_info; - return downloader and value.ToArtifacts(&artifacts_info) and - downloader(artifacts_info); -} - -auto TargetCache::ComputeCacheDir(int index) -> std::filesystem::path { - [[maybe_unused]] auto id = CAS().StoreBlobFromBytes( - LocalExecutionConfig::ExecutionBackendDescription()); - return LocalExecutionConfig::TargetCacheDir(index); -} |