diff options
| author | Sascha Roloff <sascha.roloff@huawei.com> | 2022-10-13 11:39:13 +0200 |
|---|---|---|
| committer | Sascha Roloff <sascha.roloff@huawei.com> | 2022-10-14 12:46:42 +0200 |
| commit | f7e4ebf0e2913ff1b987e40baab5c0c809e6c0de (patch) | |
| tree | 09ae121b46743a7eb682d9ba1361a59566c558bc /src/buildtool/build_engine/target_map/target_map.cpp | |
| parent | 4d53961509015534fa10a59f4b86a20ae8a66017 (diff) | |
| download | justbuild-f7e4ebf0e2913ff1b987e40baab5c0c809e6c0de.tar.gz | |
Remove default value of ArtifactDigest::Create template parameter
This enforces the explicit specification, which object type, either file or
tree, should be used to create an artifact digest. This also avoids subtile
errors at locations as in the previous commit, where files as well as trees are
supposed to be handled, but digest creation mistakenly defaults to file object
type.
Diffstat (limited to 'src/buildtool/build_engine/target_map/target_map.cpp')
| -rw-r--r-- | src/buildtool/build_engine/target_map/target_map.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/buildtool/build_engine/target_map/target_map.cpp b/src/buildtool/build_engine/target_map/target_map.cpp index ac06250b..760e8306 100644 --- a/src/buildtool/build_engine/target_map/target_map.cpp +++ b/src/buildtool/build_engine/target_map/target_map.cpp @@ -582,7 +582,8 @@ void withDependencies( } blobs.emplace_back(data->String()); return ExpressionPtr{ArtifactDescription{ - ArtifactDigest::Create(data->String()), ObjectType::File}}; + ArtifactDigest::Create<ObjectType::File>(data->String()), + ObjectType::File}}; }}, {"TREE", [&trees](auto&& eval, auto const& expr, auto const& env) { |