diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2025-06-13 13:14:27 +0200 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2025-06-16 17:27:29 +0200 |
| commit | 223f67c2cbf4648c3aaa907ec0edf98e53b574e9 (patch) | |
| tree | 7dd1e9aa2dd8a2470984a65d841e222b2226fa59 /src/buildtool/common | |
| parent | febe0937cf4394bc0f908e13fd0b6ab63b2c29c2 (diff) | |
| download | justbuild-223f67c2cbf4648c3aaa907ec0edf98e53b574e9.tar.gz | |
Avoid unnecessary work in accessing container entries
- in sequence containers, use operator[] instead of .at() when
accessing indices guaranteed to be in bound;
- in associative containers, prefer .find() and reusing the
returned const iterator to using .contains() and .at(); while
there, make any so obtained iterators const if they are read-only.
Diffstat (limited to 'src/buildtool/common')
| -rw-r--r-- | src/buildtool/common/cli.hpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/buildtool/common/cli.hpp b/src/buildtool/common/cli.hpp index ff4db0bb..096044e0 100644 --- a/src/buildtool/common/cli.hpp +++ b/src/buildtool/common/cli.hpp @@ -26,6 +26,7 @@ #include <string> #include <thread> #include <type_traits> +#include <unordered_map> #include <vector> #include "CLI/CLI.hpp" @@ -705,8 +706,9 @@ static inline auto SetupToAddArguments( app->add_option_function<std::string>( "--resolve-special", [clargs](auto const& raw_value) { - if (kResolveSpecialMap.contains(raw_value)) { - clargs->resolve_special = kResolveSpecialMap.at(raw_value); + if (auto const it = kResolveSpecialMap.find(raw_value); + it != kResolveSpecialMap.end()) { + clargs->resolve_special = it->second; } else { Logger::Log(LogLevel::Warning, |