summaryrefslogtreecommitdiff
path: root/src/buildtool/execution_api/common
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2025-05-19 17:55:40 +0200
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2025-06-04 14:34:44 +0200
commitab7adbb24384387a5c46a6340ecdedc4c1481079 (patch)
tree11a696741dfdf2be32b2633a1e9b3bd90b24b793 /src/buildtool/execution_api/common
parentdd9fa2841fcb5983b4ea845d5f9dc1b635d8dd18 (diff)
downloadjustbuild-ab7adbb24384387a5c46a6340ecdedc4c1481079.tar.gz
Remove unneeded extra checks for upwards symlinks
Diffstat (limited to 'src/buildtool/execution_api/common')
-rw-r--r--src/buildtool/execution_api/common/TARGETS1
-rw-r--r--src/buildtool/execution_api/common/tree_reader_utils.cpp7
2 files changed, 0 insertions, 8 deletions
diff --git a/src/buildtool/execution_api/common/TARGETS b/src/buildtool/execution_api/common/TARGETS
index b13ac8b5..31a308ad 100644
--- a/src/buildtool/execution_api/common/TARGETS
+++ b/src/buildtool/execution_api/common/TARGETS
@@ -29,7 +29,6 @@
[ ["@", "json", "", "json"]
, ["src/buildtool/logging", "log_level"]
, ["src/utils/cpp", "hex_string"]
- , ["src/utils/cpp", "path"]
]
, "stage": ["src", "buildtool", "execution_api", "common"]
}
diff --git a/src/buildtool/execution_api/common/tree_reader_utils.cpp b/src/buildtool/execution_api/common/tree_reader_utils.cpp
index 2ec90cc2..4d687bc5 100644
--- a/src/buildtool/execution_api/common/tree_reader_utils.cpp
+++ b/src/buildtool/execution_api/common/tree_reader_utils.cpp
@@ -29,7 +29,6 @@
#include "src/buildtool/logging/logger.hpp"
#include "src/utils/cpp/expected.hpp"
#include "src/utils/cpp/hex_string.hpp"
-#include "src/utils/cpp/path.hpp"
namespace {
[[nodiscard]] auto CreateObjectInfo(HashFunction hash_function,
@@ -104,12 +103,6 @@ auto TreeReaderUtils::ReadObjectInfos(bazel_re::Directory const& dir,
}
for (auto const& l : dir.symlinks()) {
- // check validity of symlinks
- if (not PathIsNonUpwards(l.target())) {
- Logger::Log(
- LogLevel::Error, "found invalid symlink at {}", l.name());
- return false;
- }
if (not store_info(l.name(), CreateObjectInfo(hash_function, l))) {
return false;
}