summaryrefslogtreecommitdiff
path: root/src/buildtool/execution_api/execution_service/ac_server.cpp
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-05-14 16:48:20 +0200
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-05-15 16:46:45 +0200
commit0fd32f8b9d707d807c236156de12118b0a695d69 (patch)
tree08181c9b2d429ab896cee10302630f6972aae64a /src/buildtool/execution_api/execution_service/ac_server.cpp
parent2bcbeb55f45a6c5aa193fab06f301f7231d5f16c (diff)
downloadjustbuild-0fd32f8b9d707d807c236156de12118b0a695d69.tar.gz
logging: Do not make assumptions in emit calls
The Emit method of the Logger class, when called with a string as second argument, expects it to be a format string. It should be considered a programming error to pass a string variable as that argument without knowing for certain that it does not contain any format escape character ('{', '}'); instead, one should be conservative and use the blind format string "{}" as second argument and pass the unknown string variable as third argument.
Diffstat (limited to 'src/buildtool/execution_api/execution_service/ac_server.cpp')
-rw-r--r--src/buildtool/execution_api/execution_service/ac_server.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/buildtool/execution_api/execution_service/ac_server.cpp b/src/buildtool/execution_api/execution_service/ac_server.cpp
index 53000cad..d998bd6d 100644
--- a/src/buildtool/execution_api/execution_service/ac_server.cpp
+++ b/src/buildtool/execution_api/execution_service/ac_server.cpp
@@ -24,7 +24,7 @@ auto ActionCacheServiceImpl::GetActionResult(
const ::bazel_re::GetActionResultRequest* request,
::bazel_re::ActionResult* response) -> ::grpc::Status {
if (auto error_msg = IsAHash(request->action_digest().hash()); error_msg) {
- logger_.Emit(LogLevel::Debug, *error_msg);
+ logger_.Emit(LogLevel::Debug, "{}", *error_msg);
return ::grpc::Status{::grpc::StatusCode::INVALID_ARGUMENT, *error_msg};
}
logger_.Emit(LogLevel::Trace,