summaryrefslogtreecommitdiff
path: root/src/buildtool/execution_api/execution_service
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-03-14 16:21:55 +0100
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-03-15 13:12:48 +0100
commitd0f2ba0ab15e63aa3511218a837eb6f057632ace (patch)
tree999aabe895ceee4dc692745b759b6279abb3885c /src/buildtool/execution_api/execution_service
parent208e2af5b78167777f64864c209f0af6ad4d1ef7 (diff)
downloadjustbuild-d0f2ba0ab15e63aa3511218a837eb6f057632ace.tar.gz
Clean up more includes and targets
Some of the more specific issues addressed: - missing log_level target/include - header-only libs wrongly marking deps as private - missing/misplaced gsl includes
Diffstat (limited to 'src/buildtool/execution_api/execution_service')
-rw-r--r--src/buildtool/execution_api/execution_service/TARGETS25
-rw-r--r--src/buildtool/execution_api/execution_service/ac_server.cpp1
-rw-r--r--src/buildtool/execution_api/execution_service/ac_server.hpp1
-rw-r--r--src/buildtool/execution_api/execution_service/bytestream_server.cpp1
-rw-r--r--src/buildtool/execution_api/execution_service/bytestream_server.hpp1
-rw-r--r--src/buildtool/execution_api/execution_service/capabilities_server.cpp1
-rw-r--r--src/buildtool/execution_api/execution_service/cas_server.cpp1
-rw-r--r--src/buildtool/execution_api/execution_service/execution_server.cpp2
-rw-r--r--src/buildtool/execution_api/execution_service/execution_server.hpp1
-rw-r--r--src/buildtool/execution_api/execution_service/operations_server.cpp1
-rw-r--r--src/buildtool/execution_api/execution_service/server_implementation.cpp1
11 files changed, 29 insertions, 7 deletions
diff --git a/src/buildtool/execution_api/execution_service/TARGETS b/src/buildtool/execution_api/execution_service/TARGETS
index a7d31a27..3e195136 100644
--- a/src/buildtool/execution_api/execution_service/TARGETS
+++ b/src/buildtool/execution_api/execution_service/TARGETS
@@ -6,16 +6,17 @@
, "proto": [["@", "bazel_remote_apis", "", "remote_execution_proto"]]
, "stage": ["src", "buildtool", "execution_api", "execution_service"]
, "deps":
- [ ["src/buildtool/execution_api/local", "local"]
+ [ ["@", "gsl", "", "gsl"]
+ , ["src/buildtool/execution_api/local", "local"]
, ["src/buildtool/logging", "logging"]
, ["src/buildtool/common", "bazel_types"]
, ["src/buildtool/storage", "storage"]
]
, "private-deps":
[ ["@", "fmt", "", "fmt"]
- , ["@", "gsl", "", "gsl"]
, ["src/buildtool/storage", "storage"]
, ["src/buildtool/file_system", "file_system_manager"]
+ , ["src/buildtool/logging", "log_level"]
, "operation_cache"
, ["src/utils/cpp", "verify_hash"]
]
@@ -30,13 +31,15 @@
, "proto": [["@", "bazel_remote_apis", "", "remote_execution_proto"]]
, "stage": ["src", "buildtool", "execution_api", "execution_service"]
, "deps":
- [ ["src/buildtool/logging", "logging"]
+ [ ["@", "gsl", "", "gsl"]
+ , ["src/buildtool/logging", "logging"]
, ["src/buildtool/common", "bazel_types"]
, ["src/buildtool/storage", "storage"]
]
, "private-deps":
[ ["src/buildtool/storage", "storage"]
, ["src/buildtool/execution_api/local", "local"]
+ , ["src/buildtool/logging", "log_level"]
, ["src/utils/cpp", "verify_hash"]
]
}
@@ -55,6 +58,7 @@
]
, "private-deps":
[ ["src/buildtool/compatibility", "compatibility"]
+ , ["src/buildtool/logging", "log_level"]
, ["@", "fmt", "", "fmt"]
, ["src/buildtool/storage", "storage"]
, ["src/utils/cpp", "verify_hash"]
@@ -75,6 +79,8 @@
, "capabilities_server"
, "operations_server"
, ["src/buildtool/execution_api/remote", "config"]
+ , ["src/buildtool/logging", "log_level"]
+ , ["src/buildtool/logging", "logging"]
, ["src/buildtool/auth", "auth"]
, ["@", "json", "", "json"]
, ["src/buildtool/execution_api/local", "local"]
@@ -93,12 +99,14 @@
, "proto": [["@", "googleapis", "", "google_bytestream_proto"]]
, "stage": ["src", "buildtool", "execution_api", "execution_service"]
, "deps":
- [ ["src/buildtool/logging", "logging"]
+ [ ["@", "gsl", "", "gsl"]
+ , ["src/buildtool/logging", "logging"]
, ["src/buildtool/storage", "storage"]
]
, "private-deps":
[ ["src/buildtool/compatibility", "compatibility"]
, ["src/buildtool/execution_api/common", "bytestream-common"]
+ , ["src/buildtool/logging", "log_level"]
, ["src/utils/cpp", "tmp_dir"]
, ["@", "fmt", "", "fmt"]
, ["src/buildtool/storage", "storage"]
@@ -115,7 +123,8 @@
, "stage": ["src", "buildtool", "execution_api", "execution_service"]
, "deps": [["src/buildtool/common", "bazel_types"]]
, "private-deps":
- [ ["src/buildtool/logging", "logging"]
+ [ ["src/buildtool/logging", "log_level"]
+ , ["src/buildtool/logging", "logging"]
, ["src/buildtool/compatibility", "compatibility"]
]
}
@@ -136,7 +145,11 @@
, "deps": [["src/buildtool/logging", "logging"]]
, "proto": [["@", "googleapis", "", "google_longrunning_operations_proto"]]
, "stage": ["src", "buildtool", "execution_api", "execution_service"]
- , "private-deps": ["operation_cache", ["src/utils/cpp", "verify_hash"]]
+ , "private-deps":
+ [ "operation_cache"
+ , ["src/buildtool/logging", "log_level"]
+ , ["src/utils/cpp", "verify_hash"]
+ ]
}
, "file_chunker":
{ "type": ["@", "rules", "CC", "library"]
diff --git a/src/buildtool/execution_api/execution_service/ac_server.cpp b/src/buildtool/execution_api/execution_service/ac_server.cpp
index 84a75d18..53000cad 100644
--- a/src/buildtool/execution_api/execution_service/ac_server.cpp
+++ b/src/buildtool/execution_api/execution_service/ac_server.cpp
@@ -15,6 +15,7 @@
#include "src/buildtool/execution_api/execution_service/ac_server.hpp"
#include "fmt/core.h"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/storage/garbage_collector.hpp"
#include "src/utils/cpp/verify_hash.hpp"
diff --git a/src/buildtool/execution_api/execution_service/ac_server.hpp b/src/buildtool/execution_api/execution_service/ac_server.hpp
index ce31e0ce..d862c5da 100644
--- a/src/buildtool/execution_api/execution_service/ac_server.hpp
+++ b/src/buildtool/execution_api/execution_service/ac_server.hpp
@@ -16,6 +16,7 @@
#define AC_SERVER_HPP
#include "build/bazel/remote/execution/v2/remote_execution.grpc.pb.h"
+#include "gsl/gsl"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/logging/logger.hpp"
#include "src/buildtool/storage/storage.hpp"
diff --git a/src/buildtool/execution_api/execution_service/bytestream_server.cpp b/src/buildtool/execution_api/execution_service/bytestream_server.cpp
index 09a46110..ed5a6bc2 100644
--- a/src/buildtool/execution_api/execution_service/bytestream_server.cpp
+++ b/src/buildtool/execution_api/execution_service/bytestream_server.cpp
@@ -21,6 +21,7 @@
#include "fmt/core.h"
#include "src/buildtool/compatibility/native_support.hpp"
#include "src/buildtool/execution_api/common/bytestream_common.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/storage/garbage_collector.hpp"
#include "src/utils/cpp/tmp_dir.hpp"
#include "src/utils/cpp/verify_hash.hpp"
diff --git a/src/buildtool/execution_api/execution_service/bytestream_server.hpp b/src/buildtool/execution_api/execution_service/bytestream_server.hpp
index b69b5344..f4c000f0 100644
--- a/src/buildtool/execution_api/execution_service/bytestream_server.hpp
+++ b/src/buildtool/execution_api/execution_service/bytestream_server.hpp
@@ -16,6 +16,7 @@
#define BYTESTREAM_SERVER_HPP
#include "google/bytestream/bytestream.grpc.pb.h"
+#include "gsl/gsl"
#include "src/buildtool/logging/logger.hpp"
#include "src/buildtool/storage/storage.hpp"
diff --git a/src/buildtool/execution_api/execution_service/capabilities_server.cpp b/src/buildtool/execution_api/execution_service/capabilities_server.cpp
index 22209524..7fef8a19 100644
--- a/src/buildtool/execution_api/execution_service/capabilities_server.cpp
+++ b/src/buildtool/execution_api/execution_service/capabilities_server.cpp
@@ -15,6 +15,7 @@
#include "src/buildtool/execution_api/execution_service/capabilities_server.hpp"
#include "src/buildtool/compatibility/compatibility.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/logging/logger.hpp"
auto CapabilitiesServiceImpl::GetCapabilities(
diff --git a/src/buildtool/execution_api/execution_service/cas_server.cpp b/src/buildtool/execution_api/execution_service/cas_server.cpp
index b266cd9e..32ec1d58 100644
--- a/src/buildtool/execution_api/execution_service/cas_server.cpp
+++ b/src/buildtool/execution_api/execution_service/cas_server.cpp
@@ -24,6 +24,7 @@
#include "src/buildtool/compatibility/compatibility.hpp"
#include "src/buildtool/compatibility/native_support.hpp"
#include "src/buildtool/execution_api/execution_service/cas_utils.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/storage/garbage_collector.hpp"
#include "src/utils/cpp/verify_hash.hpp"
diff --git a/src/buildtool/execution_api/execution_service/execution_server.cpp b/src/buildtool/execution_api/execution_service/execution_server.cpp
index c6789235..f122da81 100644
--- a/src/buildtool/execution_api/execution_service/execution_server.cpp
+++ b/src/buildtool/execution_api/execution_service/execution_server.cpp
@@ -22,9 +22,9 @@
#include "execution_server.hpp"
#include "fmt/core.h"
-#include "gsl/gsl"
#include "src/buildtool/execution_api/execution_service/operation_cache.hpp"
#include "src/buildtool/file_system/file_system_manager.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/storage/garbage_collector.hpp"
#include "src/utils/cpp/verify_hash.hpp"
diff --git a/src/buildtool/execution_api/execution_service/execution_server.hpp b/src/buildtool/execution_api/execution_service/execution_server.hpp
index 6d99fb6a..198b5f14 100644
--- a/src/buildtool/execution_api/execution_service/execution_server.hpp
+++ b/src/buildtool/execution_api/execution_service/execution_server.hpp
@@ -16,6 +16,7 @@
#define EXECUTION_SERVER_HPP
#include "build/bazel/remote/execution/v2/remote_execution.grpc.pb.h"
+#include "gsl/gsl"
#include "src/buildtool/common/bazel_types.hpp"
#include "src/buildtool/execution_api/local/local_api.hpp"
#include "src/buildtool/logging/logger.hpp"
diff --git a/src/buildtool/execution_api/execution_service/operations_server.cpp b/src/buildtool/execution_api/execution_service/operations_server.cpp
index 228b3595..13a8efd6 100644
--- a/src/buildtool/execution_api/execution_service/operations_server.cpp
+++ b/src/buildtool/execution_api/execution_service/operations_server.cpp
@@ -15,6 +15,7 @@
#include "src/buildtool/execution_api/execution_service/operations_server.hpp"
#include "src/buildtool/execution_api/execution_service/operation_cache.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/utils/cpp/verify_hash.hpp"
auto OperarationsServiceImpl::GetOperation(
diff --git a/src/buildtool/execution_api/execution_service/server_implementation.cpp b/src/buildtool/execution_api/execution_service/server_implementation.cpp
index 9804c53e..3ab12696 100644
--- a/src/buildtool/execution_api/execution_service/server_implementation.cpp
+++ b/src/buildtool/execution_api/execution_service/server_implementation.cpp
@@ -32,6 +32,7 @@
#include "src/buildtool/execution_api/execution_service/execution_server.hpp"
#include "src/buildtool/execution_api/execution_service/operations_server.hpp"
#include "src/buildtool/execution_api/remote/config.hpp"
+#include "src/buildtool/logging/log_level.hpp"
#include "src/buildtool/logging/logger.hpp"
namespace {