diff options
author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-07-04 11:21:11 +0200 |
---|---|---|
committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-07-04 16:05:08 +0200 |
commit | 74f53b444853850144c3e63593f83c424e84a768 (patch) | |
tree | 6bd2ca1c22f368c1f7c1b121ce205446a136fa45 /src/buildtool/execution_api/local | |
parent | ce0f5420e60c4807cca3f57131ad24df8a6b9b4b (diff) | |
download | justbuild-74f53b444853850144c3e63593f83c424e84a768.tar.gz |
Mark more constructors 'explicit'
Since c++17 the 'explicit' keyword has use also for constructors
with more than one argument and it is recommended to use it by
default whereever implicit conversions are not expected bahaviour.
Diffstat (limited to 'src/buildtool/execution_api/local')
-rw-r--r-- | src/buildtool/execution_api/local/local_action.hpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/src/buildtool/execution_api/local/local_action.hpp b/src/buildtool/execution_api/local/local_action.hpp index 0fce3c35..b88b3a97 100644 --- a/src/buildtool/execution_api/local/local_action.hpp +++ b/src/buildtool/execution_api/local/local_action.hpp @@ -67,13 +67,14 @@ class LocalAction final : public IExecutionAction { std::chrono::milliseconds timeout_{kDefaultTimeout}; CacheFlag cache_flag_{CacheFlag::CacheOutput}; - LocalAction(gsl::not_null<Storage const*> const& storage, - ArtifactDigest root_digest, - std::vector<std::string> command, - std::vector<std::string> output_files, - std::vector<std::string> output_dirs, - std::map<std::string, std::string> env_vars, - std::map<std::string, std::string> const& properties) noexcept + explicit LocalAction( + gsl::not_null<Storage const*> const& storage, + ArtifactDigest root_digest, + std::vector<std::string> command, + std::vector<std::string> output_files, + std::vector<std::string> output_dirs, + std::map<std::string, std::string> env_vars, + std::map<std::string, std::string> const& properties) noexcept : storage_{storage}, root_digest_{std::move(root_digest)}, cmdline_{std::move(command)}, |