summaryrefslogtreecommitdiff
path: root/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-07-04 11:21:11 +0200
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2024-07-04 16:05:08 +0200
commit74f53b444853850144c3e63593f83c424e84a768 (patch)
tree6bd2ca1c22f368c1f7c1b121ce205446a136fa45 /src/buildtool/execution_api/remote/bazel/bazel_action.hpp
parentce0f5420e60c4807cca3f57131ad24df8a6b9b4b (diff)
downloadjustbuild-74f53b444853850144c3e63593f83c424e84a768.tar.gz
Mark more constructors 'explicit'
Since c++17 the 'explicit' keyword has use also for constructors with more than one argument and it is recommended to use it by default whereever implicit conversions are not expected bahaviour.
Diffstat (limited to 'src/buildtool/execution_api/remote/bazel/bazel_action.hpp')
-rw-r--r--src/buildtool/execution_api/remote/bazel/bazel_action.hpp15
1 files changed, 8 insertions, 7 deletions
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
index 5abfe57b..58e5965f 100644
--- a/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
+++ b/src/buildtool/execution_api/remote/bazel/bazel_action.hpp
@@ -50,13 +50,14 @@ class BazelAction final : public IExecutionAction {
CacheFlag cache_flag_{CacheFlag::CacheOutput};
std::chrono::milliseconds timeout_{kDefaultTimeout};
- BazelAction(std::shared_ptr<BazelNetwork> network,
- bazel_re::Digest root_digest,
- std::vector<std::string> command,
- std::vector<std::string> output_files,
- std::vector<std::string> output_dirs,
- std::map<std::string, std::string> const& env_vars,
- std::map<std::string, std::string> const& properties) noexcept;
+ explicit BazelAction(
+ std::shared_ptr<BazelNetwork> network,
+ bazel_re::Digest root_digest,
+ std::vector<std::string> command,
+ std::vector<std::string> output_files,
+ std::vector<std::string> output_dirs,
+ std::map<std::string, std::string> const& env_vars,
+ std::map<std::string, std::string> const& properties) noexcept;
[[nodiscard]] auto CreateBundlesForAction(BazelBlobContainer* blobs,
bazel_re::Digest const& exec_dir,