diff options
| author | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-18 17:51:41 +0200 |
|---|---|---|
| committer | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-23 10:54:50 +0200 |
| commit | dc1db0e8b43f5e907a3ded2e39da8b58fa50a04b (patch) | |
| tree | 7ca1dd20806fd71c42f875adc1c653df45b147b1 /src/buildtool/execution_api/remote/bazel/bazel_api.hpp | |
| parent | 6453a846e788887b6cd74d71c1873a5e3270434d (diff) | |
| download | justbuild-dc1db0e8b43f5e907a3ded2e39da8b58fa50a04b.tar.gz | |
Store HashFunction by const reference.
Despite the fact that HashFunction is a small type, it still makes sense to store it by reference to reflect the ownership. StorageConfig becomes the main holder.
Reference holders store HashFunction by const ref and aren't allowed to change it. However, they are free to return HashFunction by value since this doesn't benefit readability anyhow.
Diffstat (limited to 'src/buildtool/execution_api/remote/bazel/bazel_api.hpp')
| -rw-r--r-- | src/buildtool/execution_api/remote/bazel/bazel_api.hpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.hpp b/src/buildtool/execution_api/remote/bazel/bazel_api.hpp index 6b2a6f17..b829529c 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_api.hpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_api.hpp @@ -48,7 +48,7 @@ class BazelApi final : public IExecutionApi { gsl::not_null<Auth const*> const& auth, gsl::not_null<RetryConfig const*> const& retry_config, ExecutionConfiguration const& exec_config, - HashFunction hash_function) noexcept; + gsl::not_null<HashFunction const*> const& hash_function) noexcept; BazelApi(BazelApi const&) = delete; BazelApi(BazelApi&& other) noexcept; auto operator=(BazelApi const&) -> BazelApi& = delete; |