Clarify use of a clang-tidy check

The google-default-arguments check normally imposes that virtual
methods have no default arguments. For our use-cases, all
implementations of such methods are expected to use the same
default arguments, and thus this check is manually disabled via
NOLINT comments. However, this is not done consistently.

This commit cleans this up and clarifies our intent by:
- removing the default values (and the NOLINT statement) for all
  implementations of virtual methods with default argument values,
  matching the desired intended behaviour, but
- keeping the clang-tidy check for future cases where derived
  classes would want to provide each different defaults.

1 files changed, 0 insertions, 2 deletions

diff --git a/src/buildtool/execution_api/serve/mr_local_api.cpp b/src/buildtool/execution_api/serve/mr_local_api.cpp
index 9c58d73c..06b75c14 100644
--- a/src/buildtool/execution_api/serve/mr_local_api.cpp
+++ b/src/buildtool/execution_api/serve/mr_local_api.cpp
@@ -34,7 +34,6 @@ MRLocalApi::MRLocalApi(
       native_local_api_{native_local_api},
       compat_local_api_{compatible_local_api} {}
 
-// NOLINTNEXTLINE(google-default-arguments)
 auto MRLocalApi::RetrieveToPaths(
     std::vector<Artifact::ObjectInfo> const& artifacts_info,
     std::vector<std::filesystem::path> const& output_paths,
@@ -94,7 +93,6 @@ auto MRLocalApi::RetrieveToCas(
     return compat_local_api_->RetrieveToCas(*compat_artifacts, api);
 }
 
-// NOLINTNEXTLINE(google-default-arguments)
 auto MRLocalApi::Upload(std::unordered_set<ArtifactBlob>&& blobs,
                         bool skip_find_missing) const noexcept -> bool {
     // in native mode, dispatch to native local api