diff options
| author | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-30 12:16:43 +0200 |
|---|---|---|
| committer | Maksim Denisov <denisov.maksim@huawei.com> | 2024-10-07 13:37:39 +0200 |
| commit | ce23db59c6399199fa55b4b7dc8880522e2f1bca (patch) | |
| tree | 5b77d3c84289f023cbe6f4a81cf391a0087fe660 /src/buildtool/execution_engine | |
| parent | e5d7cb5ce5b9cc40b0c56b18980a4234118c1739 (diff) | |
| download | justbuild-ce23db59c6399199fa55b4b7dc8880522e2f1bca.tar.gz | |
Enable readability-redundant-member-init check.
Diffstat (limited to 'src/buildtool/execution_engine')
| -rw-r--r-- | src/buildtool/execution_engine/dag/dag.hpp | 8 | ||||
| -rw-r--r-- | src/buildtool/execution_engine/executor/executor.hpp | 4 | ||||
| -rw-r--r-- | src/buildtool/execution_engine/traverser/traverser.hpp | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/src/buildtool/execution_engine/dag/dag.hpp b/src/buildtool/execution_engine/dag/dag.hpp index a61143f6..cd75fde4 100644 --- a/src/buildtool/execution_engine/dag/dag.hpp +++ b/src/buildtool/execution_engine/dag/dag.hpp @@ -490,17 +490,17 @@ class DependencyGraph : DirectedAcyclicGraph { private: // List of action nodes we already created - std::vector<ActionNode::Ptr> action_nodes_{}; + std::vector<ActionNode::Ptr> action_nodes_; // List of artifact nodes we already created - std::vector<ArtifactNode::Ptr> artifact_nodes_{}; + std::vector<ArtifactNode::Ptr> artifact_nodes_; // Associates global action identifier to local node id - std::unordered_map<ActionIdentifier, ActionNodeIdentifier> action_ids_{}; + std::unordered_map<ActionIdentifier, ActionNodeIdentifier> action_ids_; // Associates global artifact identifier to local node id std::unordered_map<ArtifactIdentifier, ArtifactNodeIdentifier> - artifact_ids_{}; + artifact_ids_; [[nodiscard]] auto CreateOutputArtifactNodes( std::string const& action_id, diff --git a/src/buildtool/execution_engine/executor/executor.hpp b/src/buildtool/execution_engine/executor/executor.hpp index 3a416cfb..66790696 100644 --- a/src/buildtool/execution_engine/executor/executor.hpp +++ b/src/buildtool/execution_engine/executor/executor.hpp @@ -951,13 +951,13 @@ class Rebuilder { gsl::not_null<IExecutionApi::Ptr> const api_cached_; std::chrono::milliseconds timeout_; mutable std::mutex m_; - mutable std::vector<std::string> cache_misses_{}; + mutable std::vector<std::string> cache_misses_; mutable std::unordered_map< std::string, std::unordered_map< std::string, std::pair<Artifact::ObjectInfo, Artifact::ObjectInfo>>> - flaky_actions_{}; + flaky_actions_; [[nodiscard]] auto DetectFlakyAction( IExecutionResponse::Ptr const& response, diff --git a/src/buildtool/execution_engine/traverser/traverser.hpp b/src/buildtool/execution_engine/traverser/traverser.hpp index 8cfb991f..17ab7ac6 100644 --- a/src/buildtool/execution_engine/traverser/traverser.hpp +++ b/src/buildtool/execution_engine/traverser/traverser.hpp @@ -72,7 +72,7 @@ class Traverser { Executor const& runner_{}; DependencyGraph const& graph_; gsl::not_null<std::atomic<bool>*> failed_; - TaskSystem tasker_{}; // THIS SHOULD BE THE LAST MEMBER VARIABLE + TaskSystem tasker_; // THIS SHOULD BE THE LAST MEMBER VARIABLE // Visits discover nodes and queue visits to their children nodes. void Visit(gsl::not_null<DependencyGraph::ArtifactNode const*> |