Git CAS access: reduce log level

Trying to access a git object return a recoverable failure, hence
the failure to find the object in the git object database should
be logged at warning level at most. Moreover, in some cases we
should log that event at an even lower level, e.g., if we're just
checking the presence of the object in the local git cas to avoid
unnecessary network access.

1 files changed, 4 insertions, 2 deletions

diff --git a/src/buildtool/file_system/git_cas.cpp b/src/buildtool/file_system/git_cas.cpp
index 295b5783..1af1dde2 100644
--- a/src/buildtool/file_system/git_cas.cpp
+++ b/src/buildtool/file_system/git_cas.cpp
@@ -134,7 +134,9 @@ auto GitCAS::CreateEmpty() noexcept -> GitCASPtr {
 #endif
 }
 
-auto GitCAS::ReadObject(std::string const& id, bool is_hex_id) const noexcept
+auto GitCAS::ReadObject(std::string const& id,
+                        bool is_hex_id,
+                        LogLevel log_failure) const noexcept
     -> std::optional<std::string> {
 #ifdef BOOTSTRAP_BUILD_TOOL
     return std::nullopt;
@@ -150,7 +152,7 @@ auto GitCAS::ReadObject(std::string const& id, bool is_hex_id) const noexcept
 
     git_odb_object* obj = nullptr;
     if (git_odb_read(&obj, odb_.get(), &oid.value()) != 0) {
-        Logger::Log(LogLevel::Error,
+        Logger::Log(log_failure,
                     "reading git object {} from database failed with:\n{}",
                     is_hex_id ? id : ToHexString(id),
                     GitLastError());