diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2022-12-23 17:18:42 +0100 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2022-12-23 18:29:08 +0100 |
| commit | 0374b80dd407d7b35654a01e3c7526b749d3464e (patch) | |
| tree | d0e62aece120c764ad557501e60398317c7dc77a /src/buildtool/file_system/git_repo.cpp | |
| parent | 1de5a178bc804209eeeb512023de1ce4d77eef42 (diff) | |
| download | justbuild-0374b80dd407d7b35654a01e3c7526b749d3464e.tar.gz | |
Just-MR: Remove wrong pass-by-reference when wrapping loggers
Passing the logger by reference would require the caller to be
kept alive. Also, being a shared_ptr, the logger can be passed
by value at almost no cost.
Diffstat (limited to 'src/buildtool/file_system/git_repo.cpp')
| -rw-r--r-- | src/buildtool/file_system/git_repo.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/buildtool/file_system/git_repo.cpp b/src/buildtool/file_system/git_repo.cpp index e51c404e..7a4915a3 100644 --- a/src/buildtool/file_system/git_repo.cpp +++ b/src/buildtool/file_system/git_repo.cpp @@ -1082,7 +1082,7 @@ auto GitRepo::GetSubtreeFromPath(std::filesystem::path const& fpath, } // setup wrapped logger auto wrapped_logger = std::make_shared<anon_logger_t>( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)( fmt::format("While getting repo root from path:\n{}", msg), fatal); @@ -1095,7 +1095,7 @@ auto GitRepo::GetSubtreeFromPath(std::filesystem::path const& fpath, // setup wrapped logger wrapped_logger = std::make_shared<anon_logger_t>( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)(fmt::format("While going subtree hash retrieval from " "path:\n{}", msg), @@ -1182,7 +1182,7 @@ auto GitRepo::UpdateCommitViaTmpRepo(std::filesystem::path const& tmp_repo_path, } // setup wrapped logger auto wrapped_logger = std::make_shared<anon_logger_t>( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)( fmt::format("While doing commit update via tmp repo:\n{}", msg), @@ -1228,7 +1228,7 @@ auto GitRepo::FetchViaTmpRepo(std::filesystem::path const& tmp_repo_path, std::numeric_limits<int>::max()) == 0) { // setup wrapped logger auto wrapped_logger = std::make_shared<anon_logger_t>( - [&logger](auto const& msg, bool fatal) { + [logger](auto const& msg, bool fatal) { (*logger)( fmt::format( "While doing branch fetch via tmp repo:\n{}", msg), |