diff options
author | Oliver Reiche <oliver.reiche@huawei.com> | 2023-11-03 13:54:26 +0100 |
---|---|---|
committer | Klaus Aehlig <klaus.aehlig@huawei.com> | 2023-11-15 12:03:11 +0100 |
commit | b1397ebc4512eb73894b1d273c008233c781db61 (patch) | |
tree | 361be18e98fd9d07a98c788750c0a48051be8080 /src/buildtool/main/install_cas.cpp | |
parent | b6ff8c6d7bc2e8fe595604e0f36a6cdfa54000fc (diff) | |
download | justbuild-b1397ebc4512eb73894b1d273c008233c781db61.tar.gz |
bugfix: Also unlink symlinks before installing
Make sure that all CopyFile, WriteFile, and CreateSymlink
functions properly unlink the target file (if it exists and
overwrite requested) to avoid interferences of the install
command. With this change, the clean up step for install-cas
and the within GraphTraverser can new be omitted.
(cherry-picked from 04e2f0aa0ccfe4f39c5f6c713bde182c6b7704dd)
Diffstat (limited to 'src/buildtool/main/install_cas.cpp')
-rw-r--r-- | src/buildtool/main/install_cas.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/buildtool/main/install_cas.cpp b/src/buildtool/main/install_cas.cpp index 622e7a1f..b0a2d2f6 100644 --- a/src/buildtool/main/install_cas.cpp +++ b/src/buildtool/main/install_cas.cpp @@ -103,14 +103,6 @@ auto FetchAndInstallArtifacts( output_path.parent_path().string()); return false; } - if (FileSystemManager::Exists(output_path)) { - if (not FileSystemManager::RemoveFile(output_path)) { - Logger::Log(LogLevel::Error, - "Failed to remote target location {}.", - output_path.string()); - return false; - } - } if (not api->RetrieveToPaths( {object_info}, {output_path}, alternative_api)) { Logger::Log(LogLevel::Error, "failed to retrieve artifact."); |