diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2023-12-08 09:50:57 +0100 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2023-12-12 14:37:18 +0100 |
| commit | 708e0ada1aa52f0627f0554ad01b8d22e099850c (patch) | |
| tree | 3e0ae6f30c88ecf40807df2ac0d9beb8ce66399b /src/buildtool/serve_api/serve_service/configuration.hpp | |
| parent | 93b92ef2669bed7345eadabbf71ee30c4b7929af (diff) | |
| download | justbuild-708e0ada1aa52f0627f0554ad01b8d22e099850c.tar.gz | |
serve configuration: Fix remote execution check to allow unset value
In the scenario when 'just serve' acts as 'just execute', the
remote execution endpoint returned by the serve service should be
allowed to be empty.
In this case, from the server's perspective, there is nothing to be
checked, however a client might still want to ensure that its own
configured serve and execution endpoints match.
Diffstat (limited to 'src/buildtool/serve_api/serve_service/configuration.hpp')
| -rw-r--r-- | src/buildtool/serve_api/serve_service/configuration.hpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/buildtool/serve_api/serve_service/configuration.hpp b/src/buildtool/serve_api/serve_service/configuration.hpp index 9bd3c892..c466576f 100644 --- a/src/buildtool/serve_api/serve_service/configuration.hpp +++ b/src/buildtool/serve_api/serve_service/configuration.hpp @@ -20,6 +20,11 @@ class ConfigurationService final : public justbuild::just_serve::Configuration::Service { public: + // Returns the address of the associated remote endpoint, if set, + // or an empty string signaling that the serve endpoint acts also + // as a remote execution endpoint. + // + // There are no method-specific errors. auto RemoteExecutionEndpoint( ::grpc::ServerContext* context, const ::justbuild::just_serve::RemoteExecutionEndpointRequest* request, |