diff options
author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-03-05 18:11:00 +0100 |
---|---|---|
committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-03-07 09:34:01 +0100 |
commit | fc11ad845a3d3d4c0d708b715cf9fb5e4c8fbd07 (patch) | |
tree | 5542d40cde2b2d2297c6b221bc29ca50abaa99f2 /src/buildtool/serve_api/serve_service/target.hpp | |
parent | ae16d8be16e4104eaab130b0f1e18883e22bf742 (diff) | |
download | justbuild-fc11ad845a3d3d4c0d708b715cf9fb5e4c8fbd07.tar.gz |
exceptions handling: small improvements
It is better to avoid empty catches when we have a reasonable way
to log an (even unlikely) exception, even more so if memory
allocations are involved.
Diffstat (limited to 'src/buildtool/serve_api/serve_service/target.hpp')
-rw-r--r-- | src/buildtool/serve_api/serve_service/target.hpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/buildtool/serve_api/serve_service/target.hpp b/src/buildtool/serve_api/serve_service/target.hpp index 9ab10d09..df42a87b 100644 --- a/src/buildtool/serve_api/serve_service/target.hpp +++ b/src/buildtool/serve_api/serve_service/target.hpp @@ -118,7 +118,7 @@ class TargetService final : public justbuild::just_serve::Target::Service { /// also ensures the content has the expected format. /// \returns An error + data union, with a pair of grpc status at index 0 /// and the dispatch list stored as a JSON object at index 1. - auto GetDispatchList(ArtifactDigest const& dispatch_digest) + auto GetDispatchList(ArtifactDigest const& dispatch_digest) noexcept -> std::variant<::grpc::Status, dispatch_t>; }; |