diff options
author | Maksim Denisov <denisov.maksim@huawei.com> | 2025-06-12 10:39:46 +0200 |
---|---|---|
committer | Maksim Denisov <denisov.maksim@huawei.com> | 2025-06-12 17:07:17 +0200 |
commit | 826cfa2022fbce7c3bf22b23b335f2080d878eaa (patch) | |
tree | c99b0a7ea1c46b762acbad30ab70c64b0c93eb30 /src/buildtool | |
parent | 4e0068a7e650ca9fb03e9c1a28dddcf1ddf2345c (diff) | |
download | justbuild-826cfa2022fbce7c3bf22b23b335f2080d878eaa.tar.gz |
GarbageCollector: Support removal of all generations at once
...that ignores compactification.
Diffstat (limited to 'src/buildtool')
-rw-r--r-- | src/buildtool/storage/garbage_collector.cpp | 40 | ||||
-rw-r--r-- | src/buildtool/storage/garbage_collector.hpp | 14 |
2 files changed, 46 insertions, 8 deletions
diff --git a/src/buildtool/storage/garbage_collector.cpp b/src/buildtool/storage/garbage_collector.cpp index 1ac1bf93..5014c998 100644 --- a/src/buildtool/storage/garbage_collector.cpp +++ b/src/buildtool/storage/garbage_collector.cpp @@ -70,7 +70,14 @@ auto GarbageCollector::LockFilePath( auto GarbageCollector::TriggerGarbageCollection( StorageConfig const& storage_config, - bool no_rotation) noexcept -> bool { + bool no_rotation, + bool gc_all) noexcept -> bool { + if (no_rotation and gc_all) { + Logger::Log(LogLevel::Error, + "no_rotation and gc_all cannot be set together"); + return false; + } + std::string const remove_me = "remove-me"; auto pid = CreateProcessUniqueId(); @@ -165,15 +172,38 @@ auto GarbageCollector::TriggerGarbageCollection( // Compactification must take place before rotating generations. // Otherwise, an interruption of the process during compactification // would lead to an invalid old generation. - if (not GarbageCollector::Compactify(storage_config, - MessageLimits::kMaxGrpcLength)) { + if (not gc_all and not GarbageCollector::Compactify( + storage_config, MessageLimits::kMaxGrpcLength)) { Logger::Log(LogLevel::Error, "Failed to compactify the youngest generation."); return false; } + if (gc_all) { + // Rename all cache generations starting from the oldest generation. + // If the process gets interrupted, the youngest cache stays + // available. + for (int i = static_cast<int>(storage_config.num_generations) - 1; + i >= 0; + --i) { + auto remove_me_dir = + storage_config.CacheRoot() / + fmt::format("{}{}", remove_me_prefix, remove_me_counter++); + to_remove.emplace_back(remove_me_dir); + + auto cache_root = storage_config.GenerationCacheRoot(i); + if (FileSystemManager::IsDirectory(cache_root) and + not FileSystemManager::Rename(cache_root, remove_me_dir)) { + Logger::Log(LogLevel::Error, + "Failed to rename {} to {}", + cache_root.string(), + remove_me_dir.string()); + return false; + } + } + } // Rotate generations unless told not to do so - if (not no_rotation) { + else if (not no_rotation) { auto remove_me_dir = storage_config.CacheRoot() / fmt::format("{}{}", remove_me_prefix, remove_me_counter++); @@ -216,6 +246,8 @@ auto GarbageCollector::TriggerGarbageCollection( auto GarbageCollector::Compactify(StorageConfig const& storage_config, size_t threshold) noexcept -> bool { + Logger::Log(LogLevel::Performance, "Compactification has been started"); + // Compactification must be done for both native and compatible storages. static constexpr std::array kHashes = {HashFunction::Type::GitSHA1, HashFunction::Type::PlainSHA256}; diff --git a/src/buildtool/storage/garbage_collector.hpp b/src/buildtool/storage/garbage_collector.hpp index f4966c28..e6bc8739 100644 --- a/src/buildtool/storage/garbage_collector.hpp +++ b/src/buildtool/storage/garbage_collector.hpp @@ -26,12 +26,18 @@ /// Responsible for deleting oldest generation. class GarbageCollector { public: - /// \brief Trigger garbage collection; unless no_rotation is given, this - /// will include rotation of generations and deleting the oldest generation. - /// \returns true on success. + /// \brief Trigger garbage collection + /// \param storage_config Storage to collect garbage in + /// \param no_rotation Skip rotation of generation and perform only steps + /// that can be done without losing existing cache. Incompatible with + /// gc_all. + /// \param gc_all Remove all cache generations at once. Incompatible with + /// no_rotation. + /// \return true on success. [[nodiscard]] auto static TriggerGarbageCollection( StorageConfig const& storage_config, - bool no_rotation = false) noexcept -> bool; + bool no_rotation = false, + bool gc_all = false) noexcept -> bool; /// \brief Acquire shared lock to prevent garbage collection from running. /// \param storage_config Storage to be locked. |