summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKlaus Aehlig <klaus.aehlig@huawei.com>2024-09-13 12:19:01 +0200
committerKlaus Aehlig <klaus.aehlig@huawei.com>2024-09-13 15:14:30 +0200
commitfa282d024e04fb30293409179229628f5e055cc5 (patch)
treeade68ee22c56388ea81e6a2fc9669a29eb0e0f8e /src
parent57204d29a117bd36afc7f6e07a81019d15471e8f (diff)
downloadjustbuild-fa282d024e04fb30293409179229628f5e055cc5.tar.gz
Avoid unnecessary copies
Diffstat (limited to 'src')
-rw-r--r--src/buildtool/build_engine/target_map/target_map.cpp6
-rw-r--r--src/other_tools/just_mr/utils.cpp2
2 files changed, 4 insertions, 4 deletions
diff --git a/src/buildtool/build_engine/target_map/target_map.cpp b/src/buildtool/build_engine/target_map/target_map.cpp
index 2b9ba3cd..d3fb48b7 100644
--- a/src/buildtool/build_engine/target_map/target_map.cpp
+++ b/src/buildtool/build_engine/target_map/target_map.cpp
@@ -1066,7 +1066,7 @@ void withRuleDefinition(
std::unordered_map<std::string, ExpressionPtr> params;
params.reserve(rule->ConfigFields().size() + rule->TargetFields().size() +
rule->ImplicitTargetExps().size());
- for (auto field_name : rule->ConfigFields()) {
+ for (auto const& field_name : rule->ConfigFields()) {
auto const& field_expression = data->config_exprs[field_name];
auto field_value = field_expression.Evaluate(
param_config, {}, [&logger, &field_name](auto const& msg) {
@@ -1197,10 +1197,10 @@ void withRuleDefinition(
std::vector<BuildMaps::Target::ConfiguredTarget> dependency_keys;
std::vector<BuildMaps::Target::ConfiguredTarget> transition_keys;
- for (auto target_field_name : rule->TargetFields()) {
+ for (auto const& target_field_name : rule->TargetFields()) {
auto const& deps_expression = data->target_exprs[target_field_name];
auto deps_names = deps_expression.Evaluate(
- param_config, {}, [logger, target_field_name](auto const& msg) {
+ param_config, {}, [&logger, &target_field_name](auto const& msg) {
(*logger)(
fmt::format("While evaluating target parameter {}:\n{}",
target_field_name,
diff --git a/src/other_tools/just_mr/utils.cpp b/src/other_tools/just_mr/utils.cpp
index 2243b799..9700b824 100644
--- a/src/other_tools/just_mr/utils.cpp
+++ b/src/other_tools/just_mr/utils.cpp
@@ -33,7 +33,7 @@ auto ResolveRepo(ExpressionPtr const& repo_desc,
return std::nullopt;
}
[[maybe_unused]] auto insert_res = seen->insert(desc_str);
- auto new_repo_desc = repos[desc_str];
+ auto const& new_repo_desc = repos[desc_str];
if (not new_repo_desc->IsMap()) {
Logger::Log(LogLevel::Error,
"Config: While resolving dependencies:\nDescription of "