diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2025-06-13 13:14:27 +0200 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2025-06-16 17:27:29 +0200 |
| commit | 223f67c2cbf4648c3aaa907ec0edf98e53b574e9 (patch) | |
| tree | 7dd1e9aa2dd8a2470984a65d841e222b2226fa59 /test/buildtool/build_engine/base_maps | |
| parent | febe0937cf4394bc0f908e13fd0b6ab63b2c29c2 (diff) | |
| download | justbuild-223f67c2cbf4648c3aaa907ec0edf98e53b574e9.tar.gz | |
Avoid unnecessary work in accessing container entries
- in sequence containers, use operator[] instead of .at() when
accessing indices guaranteed to be in bound;
- in associative containers, prefer .find() and reusing the
returned const iterator to using .contains() and .at(); while
there, make any so obtained iterators const if they are read-only.
Diffstat (limited to 'test/buildtool/build_engine/base_maps')
| -rw-r--r-- | test/buildtool/build_engine/base_maps/rule_map.test.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/buildtool/build_engine/base_maps/rule_map.test.cpp b/test/buildtool/build_engine/base_maps/rule_map.test.cpp index f3a64954..2b948a10 100644 --- a/test/buildtool/build_engine/base_maps/rule_map.test.cpp +++ b/test/buildtool/build_engine/base_maps/rule_map.test.cpp @@ -103,9 +103,9 @@ TEST_CASE("Test rule fields", "[rule_map]") { REQUIRE_FALSE((*values[0])->StringFields().empty()); REQUIRE_FALSE((*values[0])->TargetFields().empty()); REQUIRE_FALSE((*values[0])->ConfigFields().empty()); - CHECK((*values[0])->StringFields().at(0) == "foo"); - CHECK((*values[0])->TargetFields().at(0) == "bar"); - CHECK((*values[0])->ConfigFields().at(0) == "baz"); + CHECK((*values[0])->StringFields()[0] == "foo"); + CHECK((*values[0])->TargetFields()[0] == "bar"); + CHECK((*values[0])->ConfigFields()[0] == "baz"); }; SECTION("via file") { |