Add a test verifying that upwards outputs are rejected

This is implemented already, however as part of the tree-conflict check.

3 files changed, 71 insertions, 0 deletions

diff --git a/test/buildtool/build_engine/target_map/data_rules/simple_rules/RULES b/test/buildtool/build_engine/target_map/data_rules/simple_rules/RULES
index b8027dd7..564f7192 100644
--- a/test/buildtool/build_engine/target_map/data_rules/simple_rules/RULES
+++ b/test/buildtool/build_engine/target_map/data_rules/simple_rules/RULES
@@ -194,4 +194,15 @@
       }
     }
   }
+, "action":
+  { "string_fields": ["cmd", "outs"]
+  , "expression":
+    { "type": "RESULT"
+    , "artifacts":
+      { "type": "ACTION"
+      , "cmd": {"type": "FIELD", "name": "cmd"}
+      , "outs": {"type": "FIELD", "name": "outs"}
+      }
+    }
+  }
 }
diff --git a/test/buildtool/build_engine/target_map/data_targets/simple_targets/TARGETS b/test/buildtool/build_engine/target_map/data_targets/simple_targets/TARGETS
index 277eac77..26511ee5 100644
--- a/test/buildtool/build_engine/target_map/data_targets/simple_targets/TARGETS
+++ b/test/buildtool/build_engine/target_map/data_targets/simple_targets/TARGETS
@@ -87,4 +87,14 @@
   {"type": "file_gen", "name": "generated.txt", "data": "Hello World!"}
 , "generate symlink":
   {"type": "symlink", "name": "generated_link", "data": "dummy_link_target"}
+, "ok outs":
+  { "type": ["simple_rules", "action"]
+  , "cmd": ["sh", "-c", "mkdir foo/bar && echo hello > foo/bar/baz.txt"]
+  , "outs": ["foo/bar/baz.txt"]
+  }
+, "bad outs":
+  { "type": ["simple_rules", "action"]
+  , "cmd": ["sh", "-c", "echo hello > ../hello.txt"]
+  , "outs": ["../hello.txt"]
+  }
 }
diff --git a/test/buildtool/build_engine/target_map/target_map.test.cpp b/test/buildtool/build_engine/target_map/target_map.test.cpp
index ddcecdd0..ae376b14 100644
--- a/test/buildtool/build_engine/target_map/target_map.test.cpp
+++ b/test/buildtool/build_engine/target_map/target_map.test.cpp
@@ -546,6 +546,56 @@ TEST_CASE("simple targets", "[target_map]") {
         CHECK(result->Actions()[1]->ToJson()["input"]["in"]["data"]["path"] ==
               "simple_targets/bar.txt");
     }
+
+    SECTION("ok outs") {
+        {
+            error_msg = "NONE";
+            error = false;
+            result = nullptr;
+
+            TaskSystem ts;
+            target_map.ConsumeAfterKeysReady(
+                &ts,
+                {BuildMaps::Target::ConfiguredTarget{
+                    .target =
+                        BuildMaps::Base::EntityName{
+                            "", "simple_targets", "ok outs"},
+                    .config = empty_config}},
+                [&result](auto values) { result = *values[0]; },
+                [&error, &error_msg](std::string const& msg, bool /*unused*/) {
+                    error = true;
+                    error_msg = msg;
+                });
+        }
+        CHECK(not error);
+        CHECK(error_msg == "NONE");
+        auto artifacts_desc = result->Artifacts()->ToJson();
+        CHECK(artifacts_desc["foo/bar/baz.txt"]["type"] == "ACTION");
+    }
+
+    SECTION("bad outs") {
+        {
+            error_msg = "NONE";
+            error = false;
+            result = nullptr;
+
+            TaskSystem ts;
+            target_map.ConsumeAfterKeysReady(
+                &ts,
+                {BuildMaps::Target::ConfiguredTarget{
+                    .target =
+                        BuildMaps::Base::EntityName{
+                            "", "simple_targets", "bad outs"},
+                    .config = empty_config}},
+                [&result](auto values) { result = *values[0]; },
+                [&error, &error_msg](std::string const& msg, bool /*unused*/) {
+                    error = true;
+                    error_msg = msg;
+                });
+        }
+        CHECK(error);
+        CHECK(error_msg != "NONE");
+    }
 }
 
 TEST_CASE("configuration deduplication", "[target_map]") {