summaryrefslogtreecommitdiff
path: root/test/buildtool/execution_engine/executor/executor.test.cpp
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2025-05-16 17:35:41 +0200
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2025-06-04 14:34:44 +0200
commitdd9fa2841fcb5983b4ea845d5f9dc1b635d8dd18 (patch)
treebdd2fb1206d3d3e3d9fda6ebdfbbfd8c6aca8d4e /test/buildtool/execution_engine/executor/executor.test.cpp
parent82cae74799e5a64c819556f6152ba3734f1e2035 (diff)
downloadjustbuild-dd9fa2841fcb5983b4ea845d5f9dc1b635d8dd18.tar.gz
Executor: Check validity of action outputs in compatible mode
This ensures that any entries that the standard remote execution protocol accepts but are invalid in justbuild, i.e., upwards symlinks, are rejected. For this purpose, do not fail in the action response instances, just perform the check there, as all required information is available, and set a flag that the executor can check as needed.
Diffstat (limited to 'test/buildtool/execution_engine/executor/executor.test.cpp')
-rw-r--r--test/buildtool/execution_engine/executor/executor.test.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/test/buildtool/execution_engine/executor/executor.test.cpp b/test/buildtool/execution_engine/executor/executor.test.cpp
index 93dd10b6..cba6c977 100644
--- a/test/buildtool/execution_engine/executor/executor.test.cpp
+++ b/test/buildtool/execution_engine/executor/executor.test.cpp
@@ -139,6 +139,10 @@ class TestResponse : public IExecutionResponse {
static const DirSymlinks kEmptySymlinks{};
return gsl::not_null<DirSymlinks const*>(&kEmptySymlinks);
}
+ [[nodiscard]] auto HasUpwardsSymlinks() noexcept
+ -> expected<bool, std::string> final {
+ return false;
+ }
private:
TestApiConfig config_{};