diff options
Diffstat (limited to 'src/buildtool/execution_api')
8 files changed, 3 insertions, 13 deletions
diff --git a/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.cpp b/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.cpp index 5bed3dfc..9eaecd7a 100644 --- a/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.cpp +++ b/src/buildtool/execution_api/bazel_msg/bazel_msg_factory.cpp @@ -232,7 +232,6 @@ struct DirectoryNodeBundle final { } /// \brief Convert `DirectoryTree` to `DirectoryNodeBundle`. -/// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto DirectoryTreeToBundle( std::string const& root_name, DirectoryTreePtr const& tree, diff --git a/src/buildtool/execution_api/bazel_msg/directory_tree.cpp b/src/buildtool/execution_api/bazel_msg/directory_tree.cpp index 5b3b20e2..c7ddfdef 100644 --- a/src/buildtool/execution_api/bazel_msg/directory_tree.cpp +++ b/src/buildtool/execution_api/bazel_msg/directory_tree.cpp @@ -51,7 +51,6 @@ auto DirectoryTree::FromNamedArtifacts( return dir_tree; } -// NOLINTNEXTLINE(misc-no-recursion) auto DirectoryTree::AddArtifact(std::filesystem::path::iterator* begin, std::filesystem::path::iterator const& end, Artifact const* artifact) -> bool { diff --git a/src/buildtool/execution_api/common/blob_tree.cpp b/src/buildtool/execution_api/common/blob_tree.cpp index daf2a87c..6bb503b7 100644 --- a/src/buildtool/execution_api/common/blob_tree.cpp +++ b/src/buildtool/execution_api/common/blob_tree.cpp @@ -25,7 +25,6 @@ #include "src/buildtool/file_system/object_type.hpp" #include "src/utils/cpp/hex_string.hpp" -/// NOLINTNEXTLINE(misc-no-recursion) auto BlobTree::FromDirectoryTree(DirectoryTreePtr const& tree, std::filesystem::path const& parent) noexcept -> std::optional<BlobTreePtr> { diff --git a/src/buildtool/execution_api/common/common_api.cpp b/src/buildtool/execution_api/common/common_api.cpp index 319be597..c21d14a4 100644 --- a/src/buildtool/execution_api/common/common_api.cpp +++ b/src/buildtool/execution_api/common/common_api.cpp @@ -81,7 +81,6 @@ auto CommonRetrieveToFds( return true; } -/// NOLINTNEXTLINE(misc-no-recursion) auto CommonUploadBlobTree(BlobTreePtr const& blob_tree, IExecutionApi const& api) noexcept -> bool { // Create digest list from blobs for batch availability check. diff --git a/src/buildtool/execution_api/git/git_api.hpp b/src/buildtool/execution_api/git/git_api.hpp index 1c7edca0..aab488b3 100644 --- a/src/buildtool/execution_api/git/git_api.hpp +++ b/src/buildtool/execution_api/git/git_api.hpp @@ -53,7 +53,7 @@ class GitApi final : public IExecutionApi { return nullptr; } - // NOLINTNEXTLINE(misc-no-recursion,google-default-arguments) + // NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto RetrieveToPaths( std::vector<Artifact::ObjectInfo> const& artifacts_info, std::vector<std::filesystem::path> const& output_paths, @@ -172,7 +172,6 @@ class GitApi final : public IExecutionApi { return true; } - // NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto RetrieveToCas( std::vector<Artifact::ObjectInfo> const& artifacts_info, IExecutionApi const& api) const noexcept -> bool override { diff --git a/src/buildtool/execution_api/local/local_api.hpp b/src/buildtool/execution_api/local/local_api.hpp index 7ba26b3d..2302cb5c 100644 --- a/src/buildtool/execution_api/local/local_api.hpp +++ b/src/buildtool/execution_api/local/local_api.hpp @@ -79,7 +79,7 @@ class LocalApi final : public IExecutionApi { properties}}; } - // NOLINTNEXTLINE(misc-no-recursion,google-default-arguments) + // NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto RetrieveToPaths( std::vector<Artifact::ObjectInfo> const& artifacts_info, std::vector<std::filesystem::path> const& output_paths, @@ -154,7 +154,6 @@ class LocalApi final : public IExecutionApi { }); } - // NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto RetrieveToCas( std::vector<Artifact::ObjectInfo> const& artifacts_info, IExecutionApi const& api) const noexcept -> bool final { diff --git a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp index 1b2933af..c9206d1b 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_api.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_api.cpp @@ -230,7 +230,7 @@ auto BazelApi::CreateAction( properties}}; } -// NOLINTNEXTLINE(misc-no-recursion, google-default-arguments) +// NOLINTNEXTLINE(google-default-arguments) [[nodiscard]] auto BazelApi::RetrieveToPaths( std::vector<Artifact::ObjectInfo> const& artifacts_info, std::vector<std::filesystem::path> const& output_paths, @@ -323,7 +323,6 @@ auto BazelApi::CreateAction( ); } -// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto BazelApi::RetrieveToCas( std::vector<Artifact::ObjectInfo> const& artifacts_info, IExecutionApi const& api) const noexcept -> bool { @@ -382,7 +381,6 @@ auto BazelApi::CreateAction( artifacts_info, api, jobs, use_blob_splitting, &done); } -/// NOLINTNEXTLINE(misc-no-recursion) [[nodiscard]] auto BazelApi::ParallelRetrieveToCasWithCache( std::vector<Artifact::ObjectInfo> const& all_artifacts_info, IExecutionApi const& api, diff --git a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp index 91498b22..e4ce1ce0 100644 --- a/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp +++ b/src/buildtool/execution_api/remote/bazel/bazel_cas_client.cpp @@ -263,7 +263,6 @@ auto BazelCasClient::BatchReadBlobs( return result; } -// NOLINTNEXTLINE(misc-no-recursion) auto BazelCasClient::GetTree(std::string const& instance_name, bazel_re::Digest const& root_digest, std::int32_t page_size, @@ -484,7 +483,6 @@ auto BazelCasClient::FindMissingBlobs(std::string const& instance_name, return result; } -// NOLINTNEXTLINE(misc-no-recursion) auto BazelCasClient::BatchUpdateBlobs( std::string const& instance_name, std::vector<gsl::not_null<BazelBlob const*>>::const_iterator const& begin, |