Age | Commit message (Collapse) | Author | |
---|---|---|---|
2024-07-19 | just: Fix operation cache threshold exponent maximum value | Paul Cristian Sarbu | |
The threshold exponent cannot pass the log2 of the maximum internal map size, of type size_t, thus it cannot be larger than 63. Update the documentation and enforce the upper limit of this argument during parsing of the command line. | |||
2024-07-19 | just: Minimize needed config for 'just execute' | Paul Cristian Sarbu | |
As 'just execute' does not actually use the remote api, the configuration instances created for it can be streamlined or moved out of its scope. | |||
2024-07-19 | api_test: Rename SetLauncher to CreateLocalExecConfig | Paul Cristian Sarbu | |
This is in line with similar change in other tests, as this name is more appropriate for its purpose. | |||
2024-07-18 | just-mr: Fix wrong exit code for --help call | Paul Cristian Sarbu | |
Due to the specifics of how CLI11 library handles the --help argument and the fact that just-mr uses its own set of exit codes, we were correctly printing the help text, but falsely returning a non-zero exit code as result. This is now fixed. | |||
2024-07-17 | Test ["end-to-end/gc", "reconstruct-executable"]: drop unnecessary restriction | Klaus Aehlig | |
This test verifies properties of just, hence the precise nature of the just-mr tool does not matter. | |||
2024-07-16 | Remove the RemoteExecutionConfig singleton | Paul Cristian Sarbu | |
...and replace it with passed instances created early via a builder pattern. Tests are also updated accordingly. | |||
2024-07-16 | Use RemoteExecutionConfig instances stored in ApiBundle | Paul Cristian Sarbu | |
...wherever an ApiBundle is already being passed. | |||
2024-07-16 | Pass RemoteExecutionConfig instance to ApiBundle | Paul Cristian Sarbu | |
...and store it as a const ref for subsequent use wherever the apis are already passed. | |||
2024-07-16 | TargetCache: Use StorageConfig instance for sharding | Paul Cristian Sarbu | |
Instead of computing the shard based on the RemoteExecutionConfig singleton, use the already computed hash stored in the passed StorageConfig instance, which now needs to be set up separately if bootstrapping in order to avoid unwanted includes. Storing the backend description to CAS and corresponding audit checks now take place in main. | |||
2024-07-16 | StorageConfig: Store also the execution backend description id | Paul Cristian Sarbu | |
...such that it will be available to the TargetCache for sharing. Also, GC does not require remote execution information, so the logic for this subcommand is moved earlier in main. | |||
2024-07-16 | target service: Replace duplicated code in TC shard computation | Paul Cristian Sarbu | |
...by using the new DescribeBackend method instead. This ensures that the TC shard computation is indeed consistent between local and serve endpoint. | |||
2024-07-16 | Create separate library for DescribeBackend | Paul Cristian Sarbu | |
2024-07-16 | Add useful aliases for platform properties and dispatch endpoint | Paul Cristian Sarbu | |
2024-07-16 | Remove the LocalExecutionConfig singleton | Paul Cristian Sarbu | |
...and replace it with passed instances created early via a builder pattern. | |||
2024-07-16 | Pass LocalExecutionConfig to TargetService | Paul Cristian Sarbu | |
2024-07-16 | Pass LocalExecutionConfig to ApiBundle | Paul Cristian Sarbu | |
2024-07-16 | Pass LocalExecutionConfig to LocalAction and LocalApi | Paul Cristian Sarbu | |
2024-07-16 | LocalAction, BazelAction: Extend constness in fields and methods | Paul Cristian Sarbu | |
2024-07-16 | Remove Data struct from LocalExecutionConfig | Paul Cristian Sarbu | |
...to simplify the class and clarify the singleton pattern in preparation for its removal. | |||
2024-07-16 | Add missing RemoteExecutionConfig includes | Paul Cristian Sarbu | |
2024-07-16 | Ensure config builders always have a valid state | Paul Cristian Sarbu | |
...by making the respective Build methods const. It should be perfectly valid for multiple Build calls to happen for the same builder instance, so its internal state should never be invalidated by, e.g., moving from internal fields. | |||
2024-07-16 | test_auth_config: Fix wrong deps | Paul Cristian Sarbu | |
2024-07-16 | test: Reduce verbosity in config methods | Paul Cristian Sarbu | |
As the classes describe the config type, their static creators can have generic names, which reduces unnecessary verbosity. | |||
2024-07-16 | Set compatibility in tests | Maksim Denisov | |
2024-07-16 | Check compatibility in the test of large_object_cas | Maksim Denisov | |
2024-07-16 | Check compatibility in the test of cas_server | Maksim Denisov | |
2024-07-16 | Check compatibility in the test of file_root | Maksim Denisov | |
2024-07-16 | Check compatibility in the test of source_map | Maksim Denisov | |
2024-07-16 | Set compatibility in tests for Serve | Maksim Denisov | |
2024-07-16 | Add a test verifying that reconstructed executables are usable | Klaus Aehlig | |
... ensuring we do not regress on the recently fixed race that allowed file descriptors to reconstructed executables to be kept alive. | |||
2024-07-15 | Update CHANGELOG with latest fixes | Klaus Aehlig | |
2024-07-12 | Make end-to-end tests independent of the user's rc file | Klaus Aehlig | |
Our end-to-end tests involve calling just-mr. When run locally, in order to make then self-contained we need to make sure this test call to just-mr does not pick up the user's .just-mrrc that might contain different setting not overridden at the command line. | |||
2024-07-12 | Remove redundant ArtifactFactory class used in tests only | Maksim Denisov | |
...and move the related tests to artifact_description.test | |||
2024-07-12 | ArtifactFactory: remove FromDescription method | Maksim Denisov | |
...since it is used in tests only. | |||
2024-07-12 | ArtifactFactory: remove Identifier method | Maksim Denisov | |
...since it is used in tests only. It also duplicated serialization-deserialization of ArtifactDescription. | |||
2024-07-12 | Use precalculated hash for comparison of ArtifactDescriptions | Maksim Denisov | |
...instead of comparing raw data. | |||
2024-07-12 | Use static Create functions to construct ArtifactDescription | Maksim Denisov | |
...instead of unobvious ctors relying on overload resolution. | |||
2024-07-12 | Move implementation details of ArtifactDescription to the cpp file | Maksim Denisov | |
2024-07-12 | DAG: remove methods used in tests only | Maksim Denisov | |
2024-07-12 | DAG: remove IsValid since it is used in tests only. | Maksim Denisov | |
2024-07-12 | DAG: remove unused methods | Maksim Denisov | |
2024-07-12 | Capture in TreeReaders by pointer to avoid temporaries | Maksim Denisov | |
2024-07-12 | Replace IBundle classes family with BazelBlob | Maksim Denisov | |
2024-07-12 | Return std::nullopt if creation of an action digest fails | Maksim Denisov | |
...instead of dereferencing nullptr. | |||
2024-07-12 | Pack arguments of CreateActionDigestFromCommandLine to a struct | Maksim Denisov | |
2024-07-12 | Remove unused parameters in CreateDirectoryDigestFromTree | Maksim Denisov | |
2024-07-12 | Move BazelMsgFactory reading functions to a separate class | Maksim Denisov | |
2024-07-12 | Store newly spliced executables as copies. | Maksim Denisov | |
During multithreaded splicing, the main process can be forked (inheriting open file descriptors). In this case, the executable file saved using hardlinking becomes inaccessible. To prevent this, executables must be stored as copies made in a child process. | |||
2024-07-12 | test summary defaults: use times | Klaus Aehlig | |
... as the default summarizer can make good use of that, if provided. | |||
2024-07-12 | Internal test rules: only use in summary action what is necessary | Klaus Aehlig | |