| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
The default remote-execution protocol (which is used in compatible mode)
defines symbolic links as embedded fields within a Directory message. No
separate blobs will be stored in CAS, but they are required, e.g., when a tree
is installed. To fix that issue, we upload any symbolic link received from the
remote execution either as explicit output or as part of an output Directory
message as separate blob to the remote CAS, similar how we handle output
Directory messages themselves.
|
|
|
|
|
|
|
|
|
|
... and not only the hash of the blob containing the log of the
failed build. In compatible mode, it is necessary to have the full
digest (including the size) to download a blob from the remote CAS.
|
|
Describe the problem version 1.6.1 and earlier had when serve was
used with a strictly compatible remote execution as well as the
solution chosen in order to keep the change backwards compatible.
|
|
|
|
...and amend the error message.
|
|
...which should be downloaded before the execution starts.
|
|
... instead of relying on the default environment.
|
|
|
|
|
|
|
|
|
|
When user setting `remote-execution-properties` with commandline, we
assume that input value must have format with `key:val`, in that case,
if `val` includes colon(s), the real value after parsing won't be the
same as user intends to have, for example, considering commandline flag:
`--remote-execution-properties image:test.registry:8080/test`, will be
parsed into a pair `<image, test.registry>` in existing implementation.
Since it's reasonable to allow colon(s) in execution property value, we
should allow this case, and still keep the restriction on key format.
Signed-off-by: Bin Yu <yubin14@huawei.com>
|
|
protocol
|
|
Now that support for split/splice is part of the official
capabilites announcement, use those to determine if we should try
splitting/splicing. This change is actually mandatory as the new
standard mandates that clients must check before trying to use
the service.
Co-authored-by: Klaus Aehlig <klaus.aehlig@huawei.com>
|
|
... and drop the patch for adding split/splice, as this feature
is now standardized in the upstream API specification.
|
|
So far, blob split/splice was an extension of our build tool; now
it got standardized. Therefore we can, and hence should, use the
official proto file without modifications. As algorithm negociation
is not yet standardized, drop it for now; we will readd it, once
a standard is agreed upon.
|
|
... and while there, add Oxford comma to make the comment clearer.
|
|
While our presentation shows the details of only up to 30
non-cached actions, the count reported in the heading should
still be the total count of all non-cached actions. Fix this.
|
|
|
|
If calling just, the shared Git CAS lock, if taken, now lasts past
the exec call, the same way as the CAS lock does, in order to
prevent any rotation taking place in between.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
...as these features have already been implemented and
appropriately documented.
|
|
|
|
While there, combine all the scripts to a single section.
|
|
In commit da17ef5b04815ea3c6605274141a2e2b3b53b217, boringssl
was (among other dependencies) updated. Due to this updated, ["",
"crytpo-lib"] became a C++ library instead of a C one. Therefore,
the variables governing C++ compilation should be flexible as well.
|
|
... and while here, added the missing C compiler dependency.
|
|
|
|
|
|
As there is no guarantee that "out_dirs" are generated on action set
up, do so manually (being OK with the files already being present).
|
|
|
|
The google-default-arguments check normally imposes that virtual
methods have no default arguments. For our use-cases, all
implementations of such methods are expected to use the same
default arguments, and thus this check is manually disabled via
NOLINT comments. However, this is not done consistently.
This commit cleans this up and clarifies our intent by:
- removing the default values (and the NOLINT statement) for all
implementations of virtual methods with default argument values,
matching the desired intended behaviour, but
- keeping the clang-tidy check for future cases where derived
classes would want to provide each different defaults.
|
|
...for skipped individual check.
|
|
|
|
|
|
|
|
... and prepare local execution for clients
using only RBEv2.1 (setting only output_paths).
|
|
|
|
... as it is only needed for local execution, there is no
need to provide it in the common api interface.
|
|
|
