Age | Commit message (Collapse) | Author |
|
|
|
|
|
... instead of reporting an error, although not being fatal.
|
|
|
|
|
|
...since ArtifactBlob rehashes data on construction and guarantees that the digest matches the content.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
... and rename appropriately to reflect contents more precisely
than the generic "common". This separation also disentangles
dependencies a bit.
|
|
...by removing an extra std::vector of iterators. Instead, remove elements directly from std::unordered_set.
|
|
|
|
and drop precreated info_map.
|
|
|
|
Although references give an additional information about ownership, they introduce additional design difficulties.
|
|
|
|
|
|
|
|
|
|
The WithRetry function returns true upon success; therefore a
failure occured if the negation of the value is true. We should
report an error only in case of failure.
|
|
...and use std::unique_ptr for construction instead of std::optional.
|
|
|
|
|
|
|
|
...and pass it to BazelCasClient
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
...with direct access to mutable fields and drop additional deep copies.
|
|
|
|
...and remove ContentBlob.
|
|
|
|
...since it works with ArtifactBlobs only.
|
|
|
|
|
|
|
|
|
|
...and drop testing of invalid digests since ArtifactDigest always guarantees to hold a valid digest.
|