Age | Commit message (Collapse) | Author | |
---|---|---|---|
9 days | Clarify use of a clang-tidy check | Paul Cristian Sarbu | |
The google-default-arguments check normally imposes that virtual methods have no default arguments. For our use-cases, all implementations of such methods are expected to use the same default arguments, and thus this check is manually disabled via NOLINT comments. However, this is not done consistently. This commit cleans this up and clarifies our intent by: - removing the default values (and the NOLINT statement) for all implementations of virtual methods with default argument values, matching the desired intended behaviour, but - keeping the clang-tidy check for future cases where derived classes would want to provide each different defaults. | |||
9 days | ExecutionAPI: Support output_paths in requests | Oliver Reiche | |
... and prepare local execution for clients using only RBEv2.1 (setting only output_paths). | |||
9 days | ExecutionAPI: Support output_symlinks in response | Oliver Reiche | |
9 days | ExecutionApi: Drop DirectorySymlinks from common api | Oliver Reiche | |
... as it is only needed for local execution, there is no need to provide it in the common api interface. | |||
9 days | BazelNetwork: Read supported remote RBE version | Oliver Reiche | |
2025-06-04 | Executor: Check validity of action outputs in compatible mode | Paul Cristian Sarbu | |
This ensures that any entries that the standard remote execution protocol accepts but are invalid in justbuild, i.e., upwards symlinks, are rejected. For this purpose, do not fail in the action response instances, just perform the check there, as all required information is available, and set a flag that the executor can check as needed. | |||
2025-06-04 | {Local,Bazel}Response: Fix logic for marking succesful population | Paul Cristian Sarbu | |
While in practice a failure to populate the fields of a response happens once per invocation, as it will trigger a failure of the execution, from an algorithmic standpoint the flag to mark a successful population of the response fields should only be set on actual success. Fix this. | |||
2025-06-02 | ParallelRetrieveToCasWithCache: abort early on failure | Klaus Aehlig | |
... and do mark artifacts internally as synchronized. First all all, we will abort anyway, to the entry won't even be read and, secondly it is not necessarily true that the artifact is synchronized. | |||
2025-04-17 | bazel_execution_client: eliminate one un-needed copy | Alberto Sartori | |
2025-04-11 | Remove unused function GetTree from BazelCasClient | Klaus Aehlig | |
2025-04-11 | Drop unused directory map | Klaus Aehlig | |
The BazelNetworkReader contains an optimization for reading directories in case the remote execution (in compatible mode) supports the GetTree request. This is, however not the case for many remote exeuciton services, including our own single-node execution service. So the code is basically untested and rarely used, if at all. Moreover, justbuild is usually used in native mode and using compatibility mode is expected to handle tree operations less efficient. Therefore, remove this basically dead code and decrease complexity this way. | |||
2025-04-10 | BazelAcClient: log cache misses at trace level | Klaus Aehlig | |
... instead of at debug. We expect actions to be not in cache, so the fact that we experience cache misses is not surprising. Given the information available at this point, a useful logging indicating (in terms meaningful to the user) is not possible. Therefore, keep the debug-level log clean. | |||
2025-04-08 | BazelCasClient: only warn on failure of GetTree | Klaus Aehlig | |
... as that failure does not necessarily abort the build. | |||
2025-03-24 | BazelNetworkReader: Remove IncrementalReader | Maksim Denisov | |
2025-03-24 | BazelResponse: Use non-incremental reading | Maksim Denisov | |
to avoid downloading the same blobs. | |||
2025-03-24 | BazelApi: Use non-incremental reading | Maksim Denisov | |
...to avoid downloading the same blobs. | |||
2025-03-24 | BazelNetworkReader: Implement non-incremental reading. | Maksim Denisov | |
2025-03-24 | BazelCasClient: BatchRead to temporary files. | Maksim Denisov | |
2025-03-24 | BytestreamClient: Read to temporary files. | Maksim Denisov | |
2025-03-24 | BazelApi: Use file sources of ArtifactBlobs. | Maksim Denisov | |
2025-03-24 | ExecutionApi: Return TmpDir | Maksim Denisov | |
2025-03-24 | Pass TmpDir to BazelNetwork and BazelCasClient | Maksim Denisov | |
2025-03-24 | Remove redundant UpdateContainerAndUpload. | Maksim Denisov | |
2025-03-17 | execution_api: support reading off stdout/stderr digests | Klaus Aehlig | |
2025-03-10 | remote actions: include duration | Klaus Aehlig | |
2025-03-10 | execution response interface: include execution duration | Klaus Aehlig | |
2025-03-05 | Move obtain capabilities failures to debug log | Oliver Reiche | |
... instead of reporting an error, although not being fatal. | |||
2025-02-28 | Avoid rehashing content when using GitRepo::ReadTreeData | Maksim Denisov | |
2025-02-28 | Include ArtifactDigestFactory into "common" library | Maksim Denisov | |
2025-02-27 | BazelNetworkReader: Remove additional validation | Maksim Denisov | |
...since ArtifactBlob rehashes data on construction and guarantees that the digest matches the content. | |||
2025-02-27 | ArtifactBlob: Use static function for construction | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Check access to the content | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Support incremental reading | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Convert to a class | Maksim Denisov | |
2025-02-27 | ArtifactBlob: Move from execution_api/common to common | Maksim Denisov | |
2025-02-27 | BazelCasClient: Support request creation failure in InitRequest. | Maksim Denisov | |
2025-02-21 | ByteStreamClient: Return ArtifactBlob from Read. | Maksim Denisov | |
2025-02-21 | ByteStreamUtils: Simplify ReadRequest and WriteRequest | Maksim Denisov | |
2025-02-21 | ByteStreamClient: Use ByteStreamUtils::ReadRequest internally only. | Maksim Denisov | |
2025-02-21 | ByteStreamClient: Use ArtifactBlob in Write | Maksim Denisov | |
2025-02-21 | ByteStreamClient: Use IncrementalReader for writing | Maksim Denisov | |
2025-02-20 | Separate off id generation to a separate library | Klaus Aehlig | |
... and rename appropriately to reflect contents more precisely than the generic "common". This separation also disentangles dependencies a bit. | |||
2025-02-19 | BazelNetwork: Optimize DoUploadBlobs | Maksim Denisov | |
...by removing an extra std::vector of iterators. Instead, remove elements directly from std::unordered_set. | |||
2025-02-19 | BazelApi: Use BackMap to get missing digests | Maksim Denisov | |
2025-02-19 | BazelApi: Create BackMap in ::RetrieveToCas | Maksim Denisov | |
and drop precreated info_map. | |||
2025-02-19 | IExecutionApi: Return supported HashFunction::Type | Maksim Denisov | |
2025-02-19 | Store HashFunction by value | Maksim Denisov | |
Although references give an additional information about ownership, they introduce additional design difficulties. | |||
2025-02-19 | BazelApi: Move bazel_action and bazel_response to "bazel_api" | Maksim Denisov | |
2025-02-19 | BazelApi: rename library "bazel" => "bazel_api" | Maksim Denisov | |
2025-02-14 | ArtifactBlob: remove redundant ctor | Maksim Denisov | |