summaryrefslogtreecommitdiff
path: root/src/buildtool/execution_api/remote
AgeCommit message (Collapse)Author
9 daysClarify use of a clang-tidy checkPaul Cristian Sarbu
The google-default-arguments check normally imposes that virtual methods have no default arguments. For our use-cases, all implementations of such methods are expected to use the same default arguments, and thus this check is manually disabled via NOLINT comments. However, this is not done consistently. This commit cleans this up and clarifies our intent by: - removing the default values (and the NOLINT statement) for all implementations of virtual methods with default argument values, matching the desired intended behaviour, but - keeping the clang-tidy check for future cases where derived classes would want to provide each different defaults.
9 daysExecutionAPI: Support output_paths in requestsOliver Reiche
... and prepare local execution for clients using only RBEv2.1 (setting only output_paths).
9 daysExecutionAPI: Support output_symlinks in responseOliver Reiche
9 daysExecutionApi: Drop DirectorySymlinks from common apiOliver Reiche
... as it is only needed for local execution, there is no need to provide it in the common api interface.
9 daysBazelNetwork: Read supported remote RBE versionOliver Reiche
2025-06-04Executor: Check validity of action outputs in compatible modePaul Cristian Sarbu
This ensures that any entries that the standard remote execution protocol accepts but are invalid in justbuild, i.e., upwards symlinks, are rejected. For this purpose, do not fail in the action response instances, just perform the check there, as all required information is available, and set a flag that the executor can check as needed.
2025-06-04{Local,Bazel}Response: Fix logic for marking succesful populationPaul Cristian Sarbu
While in practice a failure to populate the fields of a response happens once per invocation, as it will trigger a failure of the execution, from an algorithmic standpoint the flag to mark a successful population of the response fields should only be set on actual success. Fix this.
2025-06-02ParallelRetrieveToCasWithCache: abort early on failureKlaus Aehlig
... and do mark artifacts internally as synchronized. First all all, we will abort anyway, to the entry won't even be read and, secondly it is not necessarily true that the artifact is synchronized.
2025-04-17bazel_execution_client: eliminate one un-needed copyAlberto Sartori
2025-04-11Remove unused function GetTree from BazelCasClientKlaus Aehlig
2025-04-11Drop unused directory mapKlaus Aehlig
The BazelNetworkReader contains an optimization for reading directories in case the remote execution (in compatible mode) supports the GetTree request. This is, however not the case for many remote exeuciton services, including our own single-node execution service. So the code is basically untested and rarely used, if at all. Moreover, justbuild is usually used in native mode and using compatibility mode is expected to handle tree operations less efficient. Therefore, remove this basically dead code and decrease complexity this way.
2025-04-10BazelAcClient: log cache misses at trace levelKlaus Aehlig
... instead of at debug. We expect actions to be not in cache, so the fact that we experience cache misses is not surprising. Given the information available at this point, a useful logging indicating (in terms meaningful to the user) is not possible. Therefore, keep the debug-level log clean.
2025-04-08BazelCasClient: only warn on failure of GetTreeKlaus Aehlig
... as that failure does not necessarily abort the build.
2025-03-24BazelNetworkReader: Remove IncrementalReaderMaksim Denisov
2025-03-24BazelResponse: Use non-incremental readingMaksim Denisov
to avoid downloading the same blobs.
2025-03-24BazelApi: Use non-incremental readingMaksim Denisov
...to avoid downloading the same blobs.
2025-03-24BazelNetworkReader: Implement non-incremental reading.Maksim Denisov
2025-03-24BazelCasClient: BatchRead to temporary files.Maksim Denisov
2025-03-24BytestreamClient: Read to temporary files.Maksim Denisov
2025-03-24BazelApi: Use file sources of ArtifactBlobs.Maksim Denisov
2025-03-24ExecutionApi: Return TmpDirMaksim Denisov
2025-03-24Pass TmpDir to BazelNetwork and BazelCasClientMaksim Denisov
2025-03-24Remove redundant UpdateContainerAndUpload.Maksim Denisov
2025-03-17execution_api: support reading off stdout/stderr digestsKlaus Aehlig
2025-03-10remote actions: include durationKlaus Aehlig
2025-03-10execution response interface: include execution durationKlaus Aehlig
2025-03-05Move obtain capabilities failures to debug logOliver Reiche
... instead of reporting an error, although not being fatal.
2025-02-28Avoid rehashing content when using GitRepo::ReadTreeDataMaksim Denisov
2025-02-28Include ArtifactDigestFactory into "common" libraryMaksim Denisov
2025-02-27BazelNetworkReader: Remove additional validationMaksim Denisov
...since ArtifactBlob rehashes data on construction and guarantees that the digest matches the content.
2025-02-27ArtifactBlob: Use static function for constructionMaksim Denisov
2025-02-27ArtifactBlob: Check access to the contentMaksim Denisov
2025-02-27ArtifactBlob: Support incremental readingMaksim Denisov
2025-02-27ArtifactBlob: Convert to a classMaksim Denisov
2025-02-27ArtifactBlob: Move from execution_api/common to commonMaksim Denisov
2025-02-27BazelCasClient: Support request creation failure in InitRequest.Maksim Denisov
2025-02-21ByteStreamClient: Return ArtifactBlob from Read.Maksim Denisov
2025-02-21ByteStreamUtils: Simplify ReadRequest and WriteRequestMaksim Denisov
2025-02-21ByteStreamClient: Use ByteStreamUtils::ReadRequest internally only.Maksim Denisov
2025-02-21ByteStreamClient: Use ArtifactBlob in WriteMaksim Denisov
2025-02-21ByteStreamClient: Use IncrementalReader for writingMaksim Denisov
2025-02-20Separate off id generation to a separate libraryKlaus Aehlig
... and rename appropriately to reflect contents more precisely than the generic "common". This separation also disentangles dependencies a bit.
2025-02-19BazelNetwork: Optimize DoUploadBlobsMaksim Denisov
...by removing an extra std::vector of iterators. Instead, remove elements directly from std::unordered_set.
2025-02-19BazelApi: Use BackMap to get missing digestsMaksim Denisov
2025-02-19BazelApi: Create BackMap in ::RetrieveToCasMaksim Denisov
and drop precreated info_map.
2025-02-19IExecutionApi: Return supported HashFunction::TypeMaksim Denisov
2025-02-19Store HashFunction by valueMaksim Denisov
Although references give an additional information about ownership, they introduce additional design difficulties.
2025-02-19BazelApi: Move bazel_action and bazel_response to "bazel_api"Maksim Denisov
2025-02-19BazelApi: rename library "bazel" => "bazel_api"Maksim Denisov
2025-02-14ArtifactBlob: remove redundant ctorMaksim Denisov