summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2024-09-23Store HashFunction by const reference.Maksim Denisov
Despite the fact that HashFunction is a small type, it still makes sense to store it by reference to reflect the ownership. StorageConfig becomes the main holder. Reference holders store HashFunction by const ref and aren't allowed to change it. However, they are free to return HashFunction by value since this doesn't benefit readability anyhow.
2024-09-19Unify logic of adding to CAS in ByteStreamServer and CASServerMaksim Denisov
...by calling the generalized CASUtils's implementation.
2024-09-19Implement CASUtils::Add{Data, File}toCASMaksim Denisov
...that both use the same templated class CASContentValidator.
2024-09-18Add LocalCAS::CheckTreeInvariant that works with file pathsMaksim Denisov
2024-09-18Use TransfromedRange in DAG to return LocalPathsMaksim Denisov
2024-09-18Add cast of TransformedRange to std::vectorMaksim Denisov
2024-09-18Add missing #endif comments in headersMaksim Denisov
2024-09-18Avoid additional memory allocations when working with protobuf's types.Maksim Denisov
Although this change doesn't benefit performance anyhow (protobuf's mutable_*() methods allocate memory lazily), it is better to let protobuf do this on its own.
2024-09-18Remove a redundant variableMaksim Denisov
2024-09-18TreeReaderUtils: change InfoStoreFunc interfaceMaksim Denisov
...passing constructed Artifact::ObjectInfo by rvalue, to avoid additional copies.
2024-09-18Implement ByteStreamUtils::WriteRequest classMaksim Denisov
...and remove split serialization/deserialization logic.
2024-09-18Implement ByteStreamUtils::ReadRequest classMaksim Denisov
...and remove split serialization/deserialization implementations.
2024-09-18Introduce ByteStreamUtils, wrap kChunkSizeMaksim Denisov
...and use the qualified name ByteStreamUtils::kChunkSize
2024-09-18Remove ByteStreamClient::{Read, Write}ManyMaksim Denisov
...since they were used only in tests.
2024-09-18Remove a redundant string allocation.Maksim Denisov
2024-09-17Small code improvements based on lint warningsPaul Cristian Sarbu
- add more noexcept requirements and enforce existing - fixing inconsistencies related to function arguments - remove redundant static keywords - silencing excessive lint reporting in test cases While there, make more getters const ref.
2024-09-16local execution: Check validity of symlinksPaul Cristian Sarbu
Invalid entries, currently all upwards symlinks (pending implementation of a better way of handling them), are now identified and handled similarly to remote execution: in compatible mode on the client side, during handling of local response, and in native mode during the population of the local action result.
2024-09-16remote execution: Check validity of symlinksPaul Cristian Sarbu
Invalid entries, currently all upwards symlinks (pending implementation of a better way of handling them), are now identified and handled properly: in compatible mode on the client side, during handling of remote response, and in native mode on the server side during the population of the action result.
2024-09-16bazel_execution_client: Remove duplication of error messagesPaul Cristian Sarbu
...during WithRetry, as we know that the error message of the callable has already been appropriately logged.
2024-09-16bazel_response: Improve error reporting for uploading treesPaul Cristian Sarbu
2024-09-16execution_response: Allow failures to be reported while populatingPaul Cristian Sarbu
As populating the containers from remote response only takes place once, no assumptions should be made that this cannot fail (for example if wrong or invalid entries were produced). Instead, return error messages on failure to callers that can log accordingly.
2024-09-13.clang-tidy: enforce more checksKlaus Aehlig
... to avoid regressing there. To be able to enable these checks also disable a false positive.
2024-09-13Avoid unnecessary copiesKlaus Aehlig
2024-09-13Avoid unnecessary creation of temporary objectKlaus Aehlig
2024-09-13Remove std::move of const value and avoid non-movable intermediate variablesKlaus Aehlig
2024-09-13Remove Compatibility flagMaksim Denisov
2024-09-13Remove Compatibility flag from justMaksim Denisov
2024-09-13Remove Compatibility flag from just-mrMaksim Denisov
2024-09-13Check compatibility in Executor based on the hash typeMaksim Denisov
2024-09-13Pass HashFunction::Type to FileRoot::AsKnownTreeMaksim Denisov
...to get the protocol type.
2024-09-13Pass HashFunction::Type to SourceTargetMapMaksim Denisov
...that is to be used by FileRoot::ToArtifactDescription.
2024-09-13Check compatibility in add_to_cas based on the hash typeMaksim Denisov
2024-09-13Pass ApiBundle to RetrieveSubPathIdMaksim Denisov
...to get access to the protocol type.
2024-09-13Check compatibility in serve services based on the hash typeMaksim Denisov
2024-09-13Pass HashFunction::Type to ConfigurationServiceMaksim Denisov
...to get the protocol type.
2024-09-13Check compatibility in execution services based on the hash typeMaksim Denisov
2024-09-13Pass HashFunction::Type to CapabilitiesServerMaksim Denisov
...to get the protocol type.
2024-09-13Pass HashFunction to BazelCasClientMaksim Denisov
...to determine whether splitting-splicing functionality is supported.
2024-09-13Check compatibility in BazelAPI based on the hash typeMaksim Denisov
2024-09-13Check compatibility in LocalAPI based on the hash typeMaksim Denisov
2024-09-13Check compatibility in Storage based on the hash typeMaksim Denisov
2024-09-13Check compatibility in readers based on the hash typeMaksim Denisov
2024-09-13Add to ProtocolTraits static functions that provide protocol-specific behaviourMaksim Denisov
2024-09-13Rename Compatibility class to ProtocolTraitsMaksim Denisov
...and move it to the common stage.
2024-09-13Move to GitHashesConverter functionality related to conversion of git hashesMaksim Denisov
...from Compatibility.
2024-09-12Prefer fseek ofer rewindKlaus Aehlig
2024-09-12Do not move variables still usedKlaus Aehlig
... depending on the evaluation order implicit in the compiler.
2024-09-12Remove unused variablesKlaus Aehlig
2024-09-12coding style: use qualified call to std::moveKlaus Aehlig
2024-09-11Store HashInfo as a field in ArtifactDigestMaksim Denisov
...and adjust ArtifactDigestFactory accordingly.