diff options
author | Maksim Denisov <denisov.maksim@huawei.com> | 2024-09-30 16:16:20 +0200 |
---|---|---|
committer | Maksim Denisov <denisov.maksim@huawei.com> | 2024-10-07 13:37:39 +0200 |
commit | 030af3e7af210617df00bf850476df6b46fb004d (patch) | |
tree | 6bfaff768b035c382fe0db07909ecd1f908f1eaf /src/buildtool/build_engine/base_maps/entity_name.hpp | |
parent | ce23db59c6399199fa55b4b7dc8880522e2f1bca (diff) | |
download | justbuild-030af3e7af210617df00bf850476df6b46fb004d.tar.gz |
Enable readability-* checks.
Diffstat (limited to 'src/buildtool/build_engine/base_maps/entity_name.hpp')
-rw-r--r-- | src/buildtool/build_engine/base_maps/entity_name.hpp | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/src/buildtool/build_engine/base_maps/entity_name.hpp b/src/buildtool/build_engine/base_maps/entity_name.hpp index def2cbe6..ad2b368d 100644 --- a/src/buildtool/build_engine/base_maps/entity_name.hpp +++ b/src/buildtool/build_engine/base_maps/entity_name.hpp @@ -112,14 +112,19 @@ template <typename T> std::optional<std::function<void(std::string const&)>> logger = std::nullopt) noexcept -> std::optional<EntityName> { try { - bool const is_file = s0 == EntityName::kFileLocationMarker; - bool const is_glob = s0 == EntityName::kGlobMarker; - bool const is_symlink = s0 == EntityName::kSymlinkLocationMarker; - auto const ref_type = - is_file ? ReferenceType::kFile - : (is_glob ? ReferenceType::kGlob - : (is_symlink ? ReferenceType::kSymlink - : ReferenceType::kTree)); + auto get_ref_type = [](std::string const& s) -> ReferenceType { + if (s == EntityName::kFileLocationMarker) { + return ReferenceType::kFile; + } + if (s == EntityName::kGlobMarker) { + return ReferenceType::kGlob; + } + if (s == EntityName::kSymlinkLocationMarker) { + return ReferenceType::kSymlink; + } + return ReferenceType::kTree; + }; + auto const ref_type = get_ref_type(s0); if (list_size == 3) { if (IsString(list[2])) { auto const& name = GetString(list[2]); |