diff options
| author | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-05-16 11:24:14 +0200 |
|---|---|---|
| committer | Paul Cristian Sarbu <paul.cristian.sarbu@huawei.com> | 2024-05-17 10:36:13 +0200 |
| commit | 580539ab08a098e7f348fee3c46fbf5d44cd4d54 (patch) | |
| tree | b73f35182abf0b278ba435925a6cc01381705fc4 /src/buildtool/build_engine/target_map/target_map.cpp | |
| parent | 0f96e596f42ef8619f173c547d7ee6c1be3aba12 (diff) | |
| download | justbuild-580539ab08a098e7f348fee3c46fbf5d44cd4d54.tar.gz | |
RepositoryConfig: Instance should not be changed once populated
Once a RepositoryConfig instance gets populated, it must never be
changed again. Therefore, all functions accepting these instances
should only take them as pointers to const.
Diffstat (limited to 'src/buildtool/build_engine/target_map/target_map.cpp')
| -rw-r--r-- | src/buildtool/build_engine/target_map/target_map.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/buildtool/build_engine/target_map/target_map.cpp b/src/buildtool/build_engine/target_map/target_map.cpp index db0d5512..0c713cd7 100644 --- a/src/buildtool/build_engine/target_map/target_map.cpp +++ b/src/buildtool/build_engine/target_map/target_map.cpp @@ -309,7 +309,7 @@ void withDependencies( const BuildMaps::Base::UserRulePtr& rule, const TargetData::Ptr& data, const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null<RepositoryConfig*>& repo_config, + const gsl::not_null<const RepositoryConfig*>& repo_config, std::unordered_map<std::string, ExpressionPtr> params, const BuildMaps::Target::TargetMap::SetterPtr& setter, const BuildMaps::Target::TargetMap::LoggerPtr& logger, @@ -994,7 +994,7 @@ void withRuleDefinition( const BuildMaps::Base::UserRulePtr& rule, const TargetData::Ptr& data, const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null<RepositoryConfig*>& repo_config, + const gsl::not_null<const RepositoryConfig*>& repo_config, const BuildMaps::Target::TargetMap::SubCallerPtr& subcaller, const BuildMaps::Target::TargetMap::SetterPtr& setter, const BuildMaps::Target::TargetMap::LoggerPtr& logger, @@ -1350,7 +1350,7 @@ void withRuleDefinition( void withTargetsFile( const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null<RepositoryConfig*>& repo_config, + const gsl::not_null<const RepositoryConfig*>& repo_config, const ActiveTargetCache& target_cache, const gsl::not_null<Statistics*>& stats, const gsl::not_null<Progress*>& exports_progress, @@ -1479,7 +1479,7 @@ void withTargetsFile( void withTargetNode( const BuildMaps::Target::ConfiguredTarget& key, - const gsl::not_null<RepositoryConfig*>& repo_config, + const gsl::not_null<const RepositoryConfig*>& repo_config, const gsl::not_null<BuildMaps::Base::UserRuleMap*>& rule_map, const gsl::not_null<TaskSystem*>& ts, const BuildMaps::Target::TargetMap::SubCallerPtr& subcaller, @@ -1777,7 +1777,7 @@ auto CreateTargetMap( directory_entries_map, const gsl::not_null<AbsentTargetMap*>& absent_target_map, const gsl::not_null<ResultTargetMap*>& result_map, - const gsl::not_null<RepositoryConfig*>& repo_config, + const gsl::not_null<const RepositoryConfig*>& repo_config, const ActiveTargetCache& target_cache, const gsl::not_null<Statistics*>& stats, const gsl::not_null<Progress*>& exports_progress, |