logging: Do not make assumptions in emit calls

The Emit method of the Logger class, when called with a string as
second argument, expects it to be a format string. It should be
considered a programming error to pass a string variable as that
argument without knowing for certain that it does not contain any
format escape character ('{', '}'); instead, one should be
conservative and use the blind format string "{}" as second
argument and pass the unknown string variable as third argument.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/buildtool/common/remote/retry.hpp b/src/buildtool/common/remote/retry.hpp
index 4e1e3492..0f82a48f 100644
--- a/src/buildtool/common/remote/retry.hpp
+++ b/src/buildtool/common/remote/retry.hpp
@@ -61,7 +61,7 @@ template <CallableReturningRetryResponse F>
             }
             if (fatal) {
                 if (error_msg) {
-                    logger.Emit(LogLevel::Error, *error_msg);
+                    logger.Emit(LogLevel::Error, "{}", *error_msg);
                 }
                 return false;
             }