Clarify use of a clang-tidy check

The google-default-arguments check normally imposes that virtual
methods have no default arguments. For our use-cases, all
implementations of such methods are expected to use the same
default arguments, and thus this check is manually disabled via
NOLINT comments. However, this is not done consistently.

This commit cleans this up and clarifies our intent by:
- removing the default values (and the NOLINT statement) for all
  implementations of virtual methods with default argument values,
  matching the desired intended behaviour, but
- keeping the clang-tidy check for future cases where derived
  classes would want to provide each different defaults.

1 files changed, 0 insertions, 3 deletions

diff --git a/src/buildtool/execution_api/local/local_api.cpp b/src/buildtool/execution_api/local/local_api.cpp
index c0a3a30e..d746c8e9 100644
--- a/src/buildtool/execution_api/local/local_api.cpp
+++ b/src/buildtool/execution_api/local/local_api.cpp
@@ -59,7 +59,6 @@ LocalApi::LocalApi(gsl::not_null<LocalContext const*> const& local_context,
     : local_context_{*local_context},
       git_api_{CreateFallbackApi(*local_context->storage, repo_config)} {}
 
-// NOLINTNEXTLINE(google-default-arguments)
 auto LocalApi::CreateAction(
     ArtifactDigest const& root_digest,
     std::vector<std::string> const& command,
@@ -102,7 +101,6 @@ auto LocalApi::CreateAction(
                                                                 properties}};
 }
 
-// NOLINTNEXTLINE(google-default-arguments)
 auto LocalApi::RetrieveToPaths(
     std::vector<Artifact::ObjectInfo> const& artifacts_info,
     std::vector<std::filesystem::path> const& output_paths,
@@ -130,7 +128,6 @@ auto LocalApi::RetrieveToPaths(
     return true;
 }
 
-// NOLINTNEXTLINE(google-default-arguments)
 auto LocalApi::RetrieveToFds(
     std::vector<Artifact::ObjectInfo> const& artifacts_info,
     std::vector<int> const& fds,