summaryrefslogtreecommitdiff
path: root/src/buildtool/file_system/git_repo.cpp
diff options
context:
space:
mode:
authorPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2023-07-04 16:13:30 +0200
committerPaul Cristian Sarbu <paul.cristian.sarbu@huawei.com>2023-07-11 11:56:33 +0200
commitcc5636adb95d6e0de1ff7858b317d7ed319c0ee8 (patch)
tree22baea879aeff43882b371b6322dc6b782a4d0b9 /src/buildtool/file_system/git_repo.cpp
parentaa7c51883c1be46a5c19b7d3ea6c48edd04b4e77 (diff)
downloadjustbuild-cc5636adb95d6e0de1ff7858b317d7ed319c0ee8.tar.gz
Git: Fix handling of symlinks in tree artifacts
The introduction of non-upwards symlinks as first-class objects should have updated the handling of known git tree artifacts containing symlinks. In particular, one should consider trees in their entirety when uploading (irrespective of the ignore_special flag), and git trees should only be reported as known only if the ignore_special flag is set to false.
Diffstat (limited to 'src/buildtool/file_system/git_repo.cpp')
-rw-r--r--src/buildtool/file_system/git_repo.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/buildtool/file_system/git_repo.cpp b/src/buildtool/file_system/git_repo.cpp
index 4dbbca39..bb60c68b 100644
--- a/src/buildtool/file_system/git_repo.cpp
+++ b/src/buildtool/file_system/git_repo.cpp
@@ -149,7 +149,9 @@ std::unordered_set<git_filemode_t> const kNonSpecialGitFileModes{
return 1; // return >=0 on success, 1 == skip subtrees (flat)
}
}
- Logger::Log(LogLevel::Error, "failed walk for git tree entry: {}", name);
+ Logger::Log(LogLevel::Error,
+ "failed ignore_special walk for git tree entry: {}",
+ name);
return -1; // fail
}